remove $.deparam and use cached query string values instead

RESOLVED FIXED

Status

Tree Management
Treeherder
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: camd, Assigned: camd)

Tracking

Details

Attachments

(1 attachment)

49 bytes, text/x-github-pull-request
mdoglio
: review+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
We are using $.deparam to parse the params on the $on $locationChangeSuccess, and just cache what they currently are, and then compare that to the new values of $location.search() before replacing the cached values.
(Assignee)

Updated

3 years ago
Assignee: nobody → cdawson
(Assignee)

Comment 1

3 years ago
Created attachment 8537502 [details] [review]
ui pr
Attachment #8537502 - Flags: review?(mdoglio)
Attachment #8537502 - Flags: review?(mdoglio) → review+

Comment 2

3 years ago
Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/4e984b7c87d611bea767b6c1b4aa8a99343b1d34
Bug 1111697 - remove $.deparam use on MainCtrl and jobfilters
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Comment 3

2 years ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/c2766ad976787daa70a4b4c330b1f9bb0843da1a
Bug 1111697 - remove $.deparam use on MainCtrl and jobfilters
You need to log in before you can comment on or make changes to this bug.