1111705 - Notification bars should show during fullscreen mode (sometimes!)

Status: RESOLVED INCOMPLETE

(Firefox :: Theme, defect)

Description

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

Per https://bugzilla.mozilla.org/show_bug.cgi?id=1076626, there is a subtle model mixup between "presentation mode" and "full screen mode" (in OSX terms.)

Claim 1:  presentation mode and 'full-screen' are similar, but not overlapping use cases.

# Presentation mode - Full screen content, no chrome should show at all.

Use cases:
- youtube or netflix is playing, we don't want bars showing.
- showing a web presentation, photo carousel, etc.

# Full screen mode - OSX style.

- should show bars, tab headers.  

Right now, these seem conflated.

(Full screen sessions are less than 1% of all sessions, fwiw., per telemetry)


Claim 2:  Separating these modes is worthwhile (especially for dev edition flows)

Why devtools should care about presentation mode on all platforms:
- parity with chrome
- getting devs to present.
- solution seems small and doable.
- good contributor project

In theme examples:

Fullscreen hides bars:
- browser/base/content/browser.css

#main-window[inFullscreen] #global-notificationbox,
#main-window[inFullscreen] #high-priority-global-notificationbox {
  visibility: collapse;
}

- browser/base/content/browser-fullScreen.js

Comment 1

[:Gijs (he/him)]

Concretely, is this a UX bug or an engineering bug, and what do you expect has happened when someone marks this as fixed? It's not clear to me from your two claims in comment #0. :-)

Comment 2

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

Gijs, will pass this off to Phlsa :)

Phlsa, see claims above, weigh in :)

(This affects Heartbeat, which can't show in fullscreen mode.)

Comment 3

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

I'm not sure I understand what the exact scope of this bug is, but I'll try to summarize:

- Notification bars should not show up at all if a website has requested fullscreen (e.g. Youtube)
- If the user manually entered presentation mode (on Windows and Linux), the notification bars should vanish along with the rest of the UI.
- Normal full-screen mode on Mac and maximized view on Windows and Linux should just show the bars as normal.

Gregg, is that what you had in mind?

Also, I didn't test any of this, so I'm not sure what the delta between the current implementation and the desired state is (but I think it's actually quite close).

Comment 4

[:Gijs (he/him)]

(In reply to Philipp Sackl [:phlsa] please use needinfo to make me respond from comment #3)
> - If the user manually entered presentation mode (on Windows and Linux), the
> notification bars should vanish along with the rest of the UI.

What is "presentation mode" ? This doesn't exist in Firefox, on Windows or Linux, nor the bug Gregg referenced, and I've never seen it mentioned on OS X, either, so it's not clear to me what this means.

Comment 5

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

re #4:  My CLAIM is the the usecases and meta-ideas of PRESENTATION mode, and FULLSCREEN mode (OSX) style are tangled, and both are implemented by FULLSCREEN mode on osx. 

Right now:

"- Normal full-screen mode on Mac and maximized view on Windows and Linux should just show the bars as normal."  

is not handled correctly, I think, and that's my request.  

There are several use cases, and I would like them all to be awesome:

- osx full screen mode (option-cmd-f)  (which has problems here)
- watching youtube (site requests 'whole screen')
- given dev talks presentations, and other 'one tab' modes.

I will dig a bit on the deltas necessary to make this all happen.  Mostly, I think it's that notification bars should show during "Normal full-screen mode on Mac and Windows", which is a Change.

Comment 6

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

(In reply to :Gijs Kruitbosch from comment #4)
> (In reply to Philipp Sackl [:phlsa] please use needinfo to make me respond
> from comment #3)
> > - If the user manually entered presentation mode (on Windows and Linux), the
> > notification bars should vanish along with the rest of the UI.
> 
> What is "presentation mode" ? This doesn't exist in Firefox, on Windows or
> Linux, nor the bug Gregg referenced, and I've never seen it mentioned on OS
> X, either, so it's not clear to me what this means.

Sorry, I got my namings wrong: There's a separate "Full Screen" mode on Windows where the toolbar/tab bar hides automatically after a delay.

Gregg, I'm sorry, but I still don't fully understand what you are asking. Could you describe the ideal state and exactly how the current state deviates from that?

Comment 7

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

OSX Full screen:  (⌘ + Shift + F)

In *that mode*, notification bars don't show.  I think this is wrong.  I don't know what happens on windows!

Comment 8

[Adrian Florinescu [:aflorinescu]]

(In reply to Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat ) from comment #7)
> OSX Full screen:  (⌘ + Shift + F)
> 
> In *that mode*, notification bars don't show.  I think this is wrong.  I
> don't know what happens on windows!

In *Windows/Linux FullScreen mode (F11)*, notification bars don't show either. IMHO i believe that's wrong as well.