|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
1.04 KB, patch
|Details | Diff | Splinter Review|
MozReview Request: Bug 1111727 - Make sure mozrunner's command line interface uses the proper profile class, r=whimboo
39 bytes, text/x-review-board-request
|Details | Review|
Starting with mozrunner 6.0 the correct runner is not detected anymore, and so the default prefs are not loaded. I noticed this while working on an upgrade patch for mozmill, when the default browser check came up during startup of Firefox. Even if you run e.g. 'mozrunner --binary /mozilla/bin/nightly/firefox' to start Firefox you can see that the default prefs are not set. It looks like that it detects only the base Runtime runner "mozrunner.base.browser.GeckoRuntimeRunner"
Ok, so it looks like that the runner class is correctly detected BUT self.profile_args() in create_runner returns an empty list of preferences. Maybe a regression in mozprofile? I will continue to check.
The problematic line of code is here: http://dxr.mozilla.org/mozilla-central/source/testing/mozbase/mozrunner/mozrunner/base/runner.py# It looks like that initially we create a base profile instance and pass this into the BaseRunner __init__ method. Due to that we do not create a FirefoxProfile instance with all the required preferences set.
Missed to add this line from where it is getting called: http://dxr.mozilla.org/mozilla-central/source/testing/mozbase/mozrunner/mozrunner/cli.py#147 Andrew, I would kinda appreciate at least a hint how to get this fixed. The mozrunner classes are kinda complex since the refactoring and without a deep dive into, I won't be able to fix it. Sadly I do not have that time. Thanks.
Summary: [mozrunner] FirefoxRunner is not getting correctly detected and fails to set default preferences → [mozrunner] CLI does not create a FirefoxProfile instance and fails to set default preferences
I'll look into it.
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Created attachment 8536789 [details] MozReview Request: bz://1111727/ahal
Attachment #8536789 - Flags: review?(hskupin)
/r/1487 - Bug 1111727 - Make sure mozrunner's command line interface uses the proper profile class, r=whimboo Pull down this commit: hg pull review -r d497b2fac6cdd3c033ef819db5ec2fa5afd29813
Attachment #8536789 - Flags: review?(hskupin) → review+
https://reviewboard.mozilla.org/r/1485/#review901 Looks great and works perfectly. Now the CLI starts Firefox correctly, and also Mozmill is able to run tests with all the default preferences set. Maybe fix the one small nit I pointed out but otherwise lets ship it. Have you run a try run, or do you want to push this directly to inbound? Can you also bump the mozrunner version later? Thanks. ::: testing/mozbase/mozrunner/mozrunner/cli.py (Diff revision 1) > -from .runners import ( > +from .application import get_app_context nit: lets add another blank line above to separate imports from local packages and the current one.
Created attachment 8537202 [details] [diff] [review] Bum to version 6.7 Sure, let's just bump it here, but as a separate commit. I fixed the nit in my local clone.
Attachment #8537202 - Flags: review?(hskupin)
Attachment #8537202 - Flags: review?(hskupin) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment on attachment 8536789 [details] MozReview Request: bz://1111727/ahal
Created attachment 8618926 [details] MozReview Request: Bug 1111727 - Make sure mozrunner's command line interface uses the proper profile class, r=whimboo
You need to log in before you can comment on or make changes to this bug.