1111752 - [B2G][Gecko][Camera] Metering mode initialized to wrong value

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Andrew Osmond [:aosmond] (he/him)]

Metering mode is initialized to center-weighted but it turns out it selects the wrong template function to set the value:

12-15 14:12:13.609  5374  5399 I Gecko   : nsresult mozilla::GonkCameraParameters::SetImpl(uint32_t, const T&) [with T = bool; nsresult = tag_nsresult; uint32_t = unsigned int]:154 -- auto-exposure

T = bool, where it should be const char* but we don't implement a SetTranslated for const char*. Easiest thing to do is to use the nsString-typed mode instead of the C string.

It will fail later in the log with:
12-15 14:12:13.649   200  5402 E QCameraParameters: Invalid auto exposure value: true

This breaks turning on the flash (somehow).

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Fix metering mode initial value, v1

try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=e3b734629fa2

Comment 2

[Mike Habicher [:mikeh] (high bugzilla latency)]

Comment on attachment 8536734 [details] [diff] [review]
Fix metering mode initial value, v1

Review of attachment 8536734 [details] [diff] [review]:
-----------------------------------------------------------------

That's embarrassing.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/11e571ee2234

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/11e571ee2234