1111801 - Kitsune can't be cloned on Windows

Status: RESOLVED FIXED

(support.mozilla.org :: Code Quality, task)

Description

[Michael Cooper [:mythmon]]

We have a file in Kitsune with a very long path that we use in tests. Most versions of Windows don't support such long file paths. Because of this, a `git clone` of Kitsune fails on Windows.

To be clear, the file path is long because it is testing long filename support.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

The file is:

kitsune/upload/test/media/long_file_namelong_file_namelong_file_namelong_file_namelong_file_namelong_file_namelong_file_namelong_file_namelong_file_namelong_file_namelong_file_namelong_file_namelong_file_namelong_file_namelong_file_namelong_file_namelong_file_name.jpg

The test in question is:

kitsune/upload/test/test_views.py:UploadImageTestCase.test_upload_long_filename

I think we can have the test create the file in question at test startup. That might work fine. Will test that first.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Wasn't able to get a working Windows dev environment going, so I wasn't able to test.

But, it's in a PR: https://github.com/mozilla/kitsune/pull/2286

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Bug #1116489 covers fixing the vagrant provisioning so it works. That'd make it possible to create a Windows dev environment to test this.

Having said that, the bug is technically fixed. The test in question will now fail on Windows. Once we get a Windows dev environment working, we can see how it fails and then tweak the test to skip. We need to be careful about that, though--we don't want it skipping all the time or skipping in scenarios it shouldn't be skipping in.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in master: https://github.com/mozilla/kitsune/commit/a8e4777525c99a74b8d06ba87ef52730ad3527bc

Since Kitsune can be cloned now, I'm going to close this out. However, we still have bug #1116489 which covers fixing peep to work with pip 6.x and after that, we'll discover that the test I changed for this bug should throw an error in Windows and we'll need to fix that.

Anyhow, marking as FIXED.