Closed Bug 1111802 Opened 6 years ago Closed 6 years ago
collapsed rocketbar is rectangular in private browsing mode
46 bytes, text/x-github-pull-request
|Details | Review|
We have to figure out if we want to ship private browsing for 2.2 but since its on master right now we have to fix it.
blocking-b2g: --- → 2.2+
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Comment on attachment 8537458 [details] [review] [PullReq] KevinGrandon:bug_1111802_private_browser_collapsed to mozilla-b2g:master This is a fairly simple background change. Etienne, I'm not sure if you remember the details of the implementation, but I would appreciate it if you could take a look if you have time. Basically we need to match the background color of the urlbar to the background color of the app chrome. This is what we do for the ".light" theme, we just need to do the same for the private browser.
Attachment #8537458 - Flags: review?(etienne)
Comment on attachment 8537458 [details] [review] [PullReq] KevinGrandon:bug_1111802_private_browser_collapsed to mozilla-b2g:master yep
Attachment #8537458 - Flags: review?(etienne) → review+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
with below build * 2.2 Build ID 20150326164141 Gaia Revision 6d0174e28576f2f93e696a43d1ac3b03340117f6 Gaia Date 2015-03-26 21:47:33 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/820c2f2e817a Gecko Version 37.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150326.201153 Firmware Date Thu Mar 26 20:12:05 EDT 2015 Bootloader L1TC000118D0 * master Build ID 20150326160206 Gaia Revision 525c341254e08f07f90da57a4d1cd5971a3cc668 Gaia Date 2015-03-26 16:34:16 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/59554288b4eb Gecko Version 39.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150326.193247 Firmware Date Thu Mar 26 19:32:58 EDT 2015 Bootloader L1TC100118D0
You need to log in before you can comment on or make changes to this bug.