Move favicons creation to Account

RESOLVED FIXED

Status

()

Firefox for iOS
Favicons
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: wesj, Assigned: wesj)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
Right now we do favicon access outside of account (It landed before account existed). We should move it inside like our other providers.

One caveat here, unlike bookmarks or history, favicons don't necessarily have to be tied to an account/profile... I'm not sure if we want to deal with that or not.
(Assignee)

Comment 1

3 years ago
Created attachment 8536783 [details] [review]
Pull request
Attachment #8536783 - Flags: review?(bnicholson)

Updated

3 years ago
Component: General → General
Product: Firefox for Android → Firefox for iOS
Assignee: nobody → wjohnston
Status: NEW → ASSIGNED
Comment on attachment 8536783 [details] [review]
Pull request

Looks good to me.
Attachment #8536783 - Flags: review?(bnicholson) → review+
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Component: General → Favicons
You need to log in before you can comment on or make changes to this bug.