Closed Bug 1111804 Opened 10 years ago Closed 10 years ago

Move favicons creation to Account

Categories

(Firefox for iOS :: Favicons, defect)

Product:
Firefox for iOS
Component:
Favicons
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: wesj, Assigned: wesj)

References

Details

Attachments

(1 file)

Pull request
46 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review 
Right now we do favicon access outside of account (It landed before account existed). We should move it inside like our other providers.

One caveat here, unlike bookmarks or history, favicons don't necessarily have to be tied to an account/profile... I'm not sure if we want to deal with that or not.
Attached file Pull request — 

        Attachment #8536783 -
        Flags: review?(bnicholson)
Product: Firefox for Android → Firefox for iOS
Assignee: nobody → wjohnston
Status: NEW → ASSIGNED

    
    

    
  
Comment on attachment 8536783 [details] [review]
Pull request

Looks good to me.

        Attachment #8536783 -
        Flags: review?(bnicholson) → review+

    
  
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Component: General → Favicons

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: