1111807 - hg pushtree is broken in tip

Status: RESOLVED FIXED

(Developer Services :: Mercurial: mozext, defect)

Description

[Benjamin Smedberg]

I was using hgext tip... if this is not the right thing to do, please let me know.

hg pushtree -r. beta
[error messages spew snipped]
hgext\mozext\__init__.py line 499 in pushtree
  return push(ui, repo, rev=[rev], dest=uri)
TypeError: push() takes at least 3 arguments (2 given)

The declaration of push() is:
def push(orig, repo, remote, *args, **kwargs)

So then I tried altering push for 3 arguments:
  push(ui, repo, uri, rev=[rev])

This seems to pass something useful to push, but now "orig" is wrong. I think this is related to this commit of hgext, but I wasn't sure what to do next:

http://hg.mozilla.org/hgcustom/version-control-tools/diff/ede56cc14d43/hgext/mozext/__init__.py

Comment 1

[Gregory Szorc [:gps]]

I'm going to remove `hg pushtree` from mozext. The firefoxtree extension supports `hg push <tree>` now.

Comment 2

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/352d7399713c

Comment 3

[Gregory Szorc [:gps]]

hg pushtree has been removed from mozext. Please use `hg push <tree>` from firefox tree instead. See https://mozilla-version-control-tools.readthedocs.org/en/latest/hgmozilla/firefoxtree.html