Closed Bug 1111810 Opened 5 years ago Closed 5 years ago

Remove Chromium IPC logging

Categories

(Core :: IPC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: jld, Assigned: jld)

Details

Attachments

(1 file)

I'm told that we're not using Chromium's IPC logging support (IPC::Logging, ipc_logging.{h,cc}, ifdef IPC_MESSAGE_LOG_ENABLED).  So it makes sense to stop compiling it; and if we're going to do that (and thus allow changes that would break it), we might as well just remove the code from ipc/chromium/src.

The logging controlled by MOZ_IPC_MESSAGE_LOG is, as far as I know, unrelated.
Comment on attachment 8536962 [details] [diff] [review]
bug1111810-rm-ipc-log-hg0.diff

Review of attachment 8536962 [details] [diff] [review]:
-----------------------------------------------------------------

r=me assuming that our own ipc logging still works... I don't think we have any tests for that, so please verify before checking in!
Attachment #8536962 - Flags: review?(bent.mozilla) → review+
(In reply to ben turner [:bent] (use the needinfo? flag!) from comment #2)
> r=me assuming that our own ipc logging still works... I don't think we have
> any tests for that, so please verify before checking in!

Verified.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7cc47794c45d
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.