1111810 - Remove Chromium IPC logging

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

I'm told that we're not using Chromium's IPC logging support (IPC::Logging, ipc_logging.{h,cc}, ifdef IPC_MESSAGE_LOG_ENABLED).  So it makes sense to stop compiling it; and if we're going to do that (and thus allow changes that would break it), we might as well just remove the code from ipc/chromium/src.

The logging controlled by MOZ_IPC_MESSAGE_LOG is, as far as I know, unrelated.

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: bug1111810-rm-ipc-log-hg0.diff

Try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=28b0be58f52a

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8536962 [details] [diff] [review]
bug1111810-rm-ipc-log-hg0.diff

Review of attachment 8536962 [details] [diff] [review]:
-----------------------------------------------------------------

r=me assuming that our own ipc logging still works... I don't think we have any tests for that, so please verify before checking in!

Comment 3

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

(In reply to ben turner [:bent] (use the needinfo? flag!) from comment #2)
> r=me assuming that our own ipc logging still works... I don't think we have
> any tests for that, so please verify before checking in!

Verified.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7cc47794c45d

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7cc47794c45d