SQLite removes %-encoding for its internal parameter lists, confuses QuotaManager

RESOLVED FIXED in mozilla37

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

Tracking

Trunk
mozilla37
x86
Windows 8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 8536839 [details] [diff] [review]
Patch, v1

I'm not sure this is a big deal (so far it only seems to affect databases opened from local files on windows systems with spaces in the path... rare!) but SQLite removes any %-encoded stuff from its uri arguments while opening databases. Then when SQLite passes them back to the QuotaManager the args don't match and so we say that the file isn't under quota control.
Attachment #8536839 - Flags: review?(Jan.Varga)

Comment 1

4 years ago
Comment on attachment 8536839 [details] [diff] [review]
Patch, v1

Review of attachment 8536839 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8536839 - Flags: review?(Jan.Varga) → review+
For posterity: http://kb.mozillazine.org/Profile_folder_-_Firefox implies that on Windows any user with a space in their user name will result in the Firefox profile existing under a directory with a space in the name.
https://hg.mozilla.org/mozilla-central/rev/2dde323fc9f4
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
(In reply to Andrew Sutherland [:asuth] from comment #3)
> For posterity: http://kb.mozillazine.org/Profile_folder_-_Firefox implies
> that on Windows any user with a space in their user name will result in the
> Firefox profile existing under a directory with a space in the name.

Yeah, but this is about the url components (the "quota group" and origin) we pass to SQLite, not the actual database file path, which we handle correctly.
You need to log in before you can comment on or make changes to this bug.