The build script of keyboard app would fail when copying the a specific ime folder for the 3rd time

RESOLVED FIXED in 2.2 S2 (19dec)

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: rudyl, Assigned: rudyl)

Tracking

unspecified
2.2 S2 (19dec)
Dependency tree / graph

Firefox Tracking Flags

(b2g-v2.2 fixed)

Details

Attachments

(1 attachment)

+++ This bug was initially created as a clone of Bug #1046900 +++

The te layout is the 3rd user of the 'india' ime engine, and our build script could not handle this case.
 1. The 1st time, no problem.
 2. The 2nd time, it would create a duplicate folder, say,
    js/imes/india/india/...

 3. The 3rd time, it would fail with NS_ERROR_FILE_ALREADY_EXISTS.

Exception: Error: Unknown ime directory /Users/rudy/Dev/gaia_dev/apps/keyboard/js/imes/india for keyboard layout te - [Exception... "Component returned failure code: 0x80520008 (NS_ERROR_FILE_ALREADY_EXISTS) [nsILocalFile.copyTo]"  nsresult: "0x80520008 (NS_ERROR_FILE_ALREADY_EXISTS)"  location: "JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> file:///Users/rudy/Dev/gaia_dev/apps/keyboard/build//keyboard-config.js :: copyLayoutsAndResources/< :: line 31"  data: no]
Created attachment 8537125 [details] [review]
Patch V1

Tim, could you please help review this patch?
Thank you.
Attachment #8537125 - Flags: review?(timdream)
Attachment #8537125 - Flags: review?(timdream) → review+
Assignee: nobody → rlu
Status: NEW → ASSIGNED
Gaia master,
https://github.com/mozilla-b2g/gaia/commit/1146f4fe9489172b6e92dc985887f2025a4d2fda

--
Thanks.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-b2g-v2.2: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S2 (19dec)
You need to log in before you can comment on or make changes to this bug.