If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

freebl Makefile needs Solaris 9 defintion

RESOLVED FIXED in 3.4

Status

NSS
Build
P1
normal
RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: km, Assigned: Wan-Teh Chang)

Tracking

unspecified
Sun
Solaris

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

16 years ago
mozilla/security/nss/lib/freebl/Makefile checks for particular Solaris
relases and sets SYSV_SPARC. 5.9 needs to be added to the list.

It currently reads

ifeq ($(OS_RELEASE),5.5.1)
    SYSV_SPARC = 1
endif
ifeq ($(OS_RELEASE),5.6)
    SYSV_SPARC = 1
endif
ifeq ($(OS_RELEASE),5.7)
    SYSV_SPARC = 1
endif
ifeq ($(OS_RELEASE),5.8)
    SYSV_SPARC = 1
endif

Comment 1

16 years ago
Confirming and making suggested fix into a patch.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: patch

Comment 2

16 years ago
Created attachment 58707 [details] [diff] [review]
patch to detect Solaris 9
(Assignee)

Comment 3

16 years ago
Thank you for the bug report and the patch.

I will come up with a different patch that
simply tests for $(OS_RELEASE) >= 5.5.1.
(I need to recall how to do that with GNU
make functions.)  This way we won't need to
change the freebl makefile again when a new
Solaris version is released.
(Assignee)

Comment 4

16 years ago
Created attachment 59273 [details] [diff] [review]
Alternate patch.  Works for all $(OS_RELEASE) >= 5.5.1.
(Assignee)

Comment 5

16 years ago
Bug reporter, please try my patch (attachment 59273 [details] [diff] [review]).

Chris, please review my patch, which uses the firstword/sort
trick I learned from you.  Thanks.
Status: NEW → ASSIGNED
Comment on attachment 59273 [details] [diff] [review]
Alternate patch.  Works for all $(OS_RELEASE) >= 5.5.1.

hehehe. r=cls
Attachment #59273 - Flags: review+
(Assignee)

Updated

16 years ago
Priority: -- → P1
Target Milestone: --- → 3.4
(Assignee)

Comment 7

16 years ago
The patch has been checked into the tip of NSS.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.