111206 - freebl Makefile needs Solaris 9 defintion

Status: RESOLVED FIXED

(NSS :: Build, defect, P1)

Description

[km]

mozilla/security/nss/lib/freebl/Makefile checks for particular Solaris
relases and sets SYSV_SPARC. 5.9 needs to be added to the list.

It currently reads

ifeq ($(OS_RELEASE),5.5.1)
    SYSV_SPARC = 1
endif
ifeq ($(OS_RELEASE),5.6)
    SYSV_SPARC = 1
endif
ifeq ($(OS_RELEASE),5.7)
    SYSV_SPARC = 1
endif
ifeq ($(OS_RELEASE),5.8)
    SYSV_SPARC = 1
endif

Comment 1

[Jim Crumley]

Confirming and making suggested fix into a patch.

Comment 2

[Jim Crumley]

Attachment: patch to detect Solaris 9

Comment 3

[Wan-Teh Chang]

Thank you for the bug report and the patch.

I will come up with a different patch that
simply tests for $(OS_RELEASE) >= 5.5.1.
(I need to recall how to do that with GNU
make functions.)  This way we won't need to
change the freebl makefile again when a new
Solaris version is released.

Comment 4

[Wan-Teh Chang]

Attachment: Alternate patch. Works for all $(OS_RELEASE) >= 5.5.1.

Comment 5

[Wan-Teh Chang]

Bug reporter, please try my patch (attachment 59273 [details] [diff] [review]).

Chris, please review my patch, which uses the firstword/sort
trick I learned from you.  Thanks.

Comment 6

[hacker formerly known as [e-mail]]

Comment on attachment 59273 [details] [diff] [review]
Alternate patch.  Works for all $(OS_RELEASE) >= 5.5.1.

hehehe. r=cls

Comment 7

[Wan-Teh Chang]

The patch has been checked into the tip of NSS.