1112105 - Please deploy Loop-Client 0.12.0 code to production

Status: VERIFIED FIXED

(Cloud Services :: Operations: Deployment Requests - DEPRECATED, task)

Description

[Mark Banner (:standard8)]

We'd like to deploy the loop-client 0.12.0 release to production.

https://github.com/mozilla/loop-client/releases/tag/0.12.0

Config changes:

To loop.config in config.js add:

  generalSupportUrl: 'https://support.mozilla.org/kb/respond-firefox-hello-invitation-guest-mode',

Comment 1

[Richard Pappalardo [:rpapa][:rpappalardo]]

------------------
SUMMARY
------------------
:deanw has deployed this to prod

placed various calls between Nightly & Beta
all looks good other than links to privacy and legal ToS in FTE conversation window both open to blank page.

NOTE: 
I believe this may be a regression. i recall this was busted and got fixed (it does work in BETA).

Dean -
can you take a look at this?


------------------
QUICK CHECKS
------------------

Browser: https://hello.firefox.com/VERSION.txt:

0.12.0
395302ecb0a9a92dc94586968cc97b660252d282 Tue, 16 Dec 2014 15:26:02 +0000

NOTE:
https://call.mozilla.org/ has now been removed.


Browser: https://hello.firefox.com/config.js:

var loop = loop || {}; loop.config = { serverUrl: 'https://loop.services.mozilla.com/v0', feedbackApiUrl: 'https://input.mozilla.org/api/v1/feedback', feedbackProductName: 'Loop', brandWebsiteUrl: 'https://www.mozilla.org/firefox/', privacyWebsiteUrl: 'https://www.mozilla.org/privacy/firefox-hello/', legalWebsiteUrl: 'https://www.mozilla.org/about/legal/terms/firefox-hello/', marketplaceUrl: 'https://marketplace.firefox.com/iframe-install.html', learnMoreUrl: 'https://www.mozilla.org/hello/', roomsSupportUrl: 'https://support.mozilla.org/kb/group-conversations-firefox-hello-webrtc', guestSupportUrl: 'https://support.mozilla.org/kb/respond-firefox-hello-invitation-guest-mode', fxosApp: { name: 'Firefox Hello', manifestUrl: 'https://marketplace.firefox.com/app/54b83aea-1208-4605-82eb-22819f39d81d/manifest.webapp' } }; 

PRIVACY & ToS LINKS

https://www.mozilla.org/about/legal/terms/firefox-hello/
https://www.mozilla.org/privacy/firefox-hello/

links to legal and privacy from Rooms - OK!
but FTE links to legal ToS and privacy both link to blank page

LOOP-SERVER

working with loop-server 0.13.2:
Browser: https://loop.services.mozilla.com:
{
  "name": "mozilla-loop-server",
  "description": "The Mozilla Loop (WebRTC App) server",
  "version": "0.13.2",
  "homepage": "https://github.com/mozilla-services/loop-server/",
  "endpoint": "https://loop.services.mozilla.com",
  "fakeTokBox": false,
  "fxaOAuth": true,
  "i18n": {
    "defaultLang": "en-US",
    "lang": "en-US"
  }
}

Comment 2

[Mark Banner (:standard8)]

(In reply to Richard Pappalardo [:rpapa][:rpappalardo] from comment #1)
> placed various calls between Nightly & Beta
> all looks good other than links to privacy and legal ToS in FTE conversation
> window both open to blank page.
> 
> NOTE: 
> I believe this may be a regression. i recall this was busted and got fixed
> (it does work in BETA).

This is bug 1095554 - its only an issue with e10s based windows, and not a website/content issue (the links are now to www.mozilla.org which also means that loop-client deploys are unlikely to affect them).

Comment 3

[Richard Pappalardo [:rpapa][:rpappalardo]]

(In reply to Mark Banner (:standard8) from comment #2)
> (In reply to Richard Pappalardo [:rpapa][:rpappalardo] from comment #1)
> > placed various calls between Nightly & Beta
> > all looks good other than links to privacy and legal ToS in FTE conversation
> > window both open to blank page.
> > 
> > NOTE: 
> > I believe this may be a regression. i recall this was busted and got fixed
> > (it does work in BETA).
> 
> This is bug 1095554 - its only an issue with e10s based windows, and not a
> website/content issue (the links are now to www.mozilla.org which also means
> that loop-client deploys are unlikely to affect them).

Thanks, Mark!  everything else looks good.
verifying