Closed
Bug 1112117
Opened 10 years ago
Closed 9 years ago
Ship-it: Introduce some js unit testing
Categories
(Release Engineering :: Release Automation: Other, defect)
Release Engineering
Release Automation: Other
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
Details
Attachments
(2 files)
|
6.38 KB,
patch
|
bhearsum
:
review+
Sylvestre
:
checked-in+
|
Details | Diff | Splinter Review |
|
5.40 KB,
patch
|
bhearsum
:
review+
|
Details | Diff | Splinter Review |
Lately, we introduce quite a few JS functions which could be easily tested. We are already running Python unit tests with nosetests, we should do the same with js.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → sledru
|
|
Assignee | |
Comment 1•10 years ago
|
||
A minor refactoring + a check added
Attachment #8537873 -
Flags: review?(bhearsum)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Here are a few js unit test. I have to dig how to call them from nosetest For now, the test HTML has to be called with file:///
Attachment #8537876 -
Flags: review?(bhearsum)
|
||
Comment 3•10 years ago
|
||
(In reply to Sylvestre Ledru [:sylvestre] from comment #2) > Created attachment 8537876 [details] [diff] [review] > 0002-Bug-1112117-Introduce-a-serie-of-JS-unit-tests.patch > > Here are a few js unit test. > I have to dig how to call them from nosetest > > For now, the test HTML has to be called with file:/// Nose is specifically for running Python tests, it won't help. It might be nice to have a small wrapper that runs both at some point though. We can run these tests headlessly with phantomjs - which is a basically the webkit JS interpreter with a DOM. This isn't a blocker though.
|
|
||
Updated•10 years ago
|
Attachment #8537873 -
Flags: review?(bhearsum) → review+
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8537876 [details] [diff] [review] 0002-Bug-1112117-Introduce-a-serie-of-JS-unit-tests.patch Review of attachment 8537876 [details] [diff] [review]: ----------------------------------------------------------------- ::: kickoff/test/jstest.html @@ +1,1 @@ > +<!DOCTYPE html> Please put these files in a subdirectory to keep them organized and separate from the python tests. eg, kickoff/test/js. r=me if you fix that on landing.
Attachment #8537876 -
Flags: review?(bhearsum) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Comment on attachment 8537873 [details] [diff] [review] 0001-move-populatePartial-outside-of-the-setupVersionSugg.patch Merged: http://git.mozilla.org/?p=build/release-kickoff.git;a=commitdiff;h=5c259efaaa17021c9aa5b16b253084c8a384ac22 http://git.mozilla.org/?p=build/release-kickoff.git;a=commitdiff;h=19657262d528f0d242272e7923cd09b216e187e6
Attachment #8537873 -
Flags: checked-in+
|
|
Assignee | |
Comment 6•9 years ago
|
||
deployed.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•