Closed
Bug 1112119
Opened 10 years ago
Closed 9 years ago
[raptor] Deprecate usage of Datazilla for Gaia performance metrics in favor of Raptor
Categories
(Firefox OS Graveyard :: Gaia::PerformanceTest, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Eli, Assigned: Eli)
References
Details
(Keywords: perf)
Attachments
(17 files, 1 obsolete file)
57 bytes,
text/x-github-pull-request
|
kgrandon
:
review+
|
Details | Review |
46 bytes,
text/x-github-pull-request
|
mmedeiros
:
review+
|
Details | Review |
46 bytes,
text/x-github-pull-request
|
mcav
:
review+
|
Details | Review |
46 bytes,
text/x-github-pull-request
|
wilsonpage
:
review+
|
Details | Review |
46 bytes,
text/x-github-pull-request
|
arcturus
:
review+
|
Details | Review |
46 bytes,
text/x-github-pull-request
|
gsvelto
:
review+
|
Details | Review |
46 bytes,
text/x-github-pull-request
|
mai
:
review+
|
Details | Review |
46 bytes,
text/x-github-pull-request
|
jrburke
:
review+
|
Details | Review |
46 bytes,
text/x-github-pull-request
|
djf
:
review+
|
Details | Review |
46 bytes,
text/x-github-pull-request
|
djf
:
review+
|
Details | Review |
46 bytes,
text/x-github-pull-request
|
djf
:
review+
|
Details | Review |
46 bytes,
text/x-github-pull-request
|
arthurcc
:
review+
|
Details | Review |
46 bytes,
text/x-github-pull-request
|
julienw
:
review+
|
Details | Review |
46 bytes,
text/x-github-pull-request
|
kgrandon
:
review+
|
Details | Review |
46 bytes,
text/x-github-pull-request
|
kgrandon
:
review+
|
Details | Review |
46 bytes,
text/x-github-pull-request
|
djf
:
review+
|
Details | Review |
46 bytes,
text/x-github-pull-request
|
gaye
:
review+
Eli
:
review+
|
Details | Review |
Once Raptor is production-ready, it will replace all of the functionality we current get from Datazilla. We will deprecate the usage of Datazilla for these metrics and use Raptor instead.
Assignee | ||
Comment 1•9 years ago
|
||
TODO for this bug: remove PerformanceTestingHelper and its methods from all Gaia applications.
Assignee: nobody → eperelman
Status: NEW → ASSIGNED
Updated•9 years ago
|
Blocks: PerformanceProgram
Assignee | ||
Comment 2•9 years ago
|
||
Also try removing exec-sync and ffi-prebuilt npm modules.
Comment 3•9 years ago
|
||
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8595363 [details] [review] [gaia-node-modules] eliperelman:bug-1112119 > mozilla-b2g:master This patch just removes the ffi-prebuilt Node module.
Attachment #8595363 -
Flags: review?(kgrandon)
Comment 5•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8595373 -
Flags: review?(mmedeiros)
Comment 6•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8595375 -
Flags: review?(m)
Comment 7•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8595380 -
Flags: review?(wilsonpage)
Comment 8•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8595381 -
Flags: review?(francisco)
Comment 9•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8595382 -
Flags: review?(gsvelto)
Comment 10•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8595383 -
Flags: review?(marina.rodrigueziglesias)
Comment 11•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8595385 -
Flags: review?(jrburke)
Comment 12•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8595386 -
Flags: review?(dflanagan)
Comment 13•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8595388 -
Flags: review?(dflanagan)
Comment 14•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8595391 -
Flags: review?(dflanagan)
Updated•9 years ago
|
Attachment #8595385 -
Flags: review?(jrburke) → review+
Comment 15•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8595393 -
Flags: review?(arthur.chen)
Comment 16•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8595394 -
Flags: review?(felash)
Comment 17•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8595395 -
Flags: review?(kgrandon)
Comment 18•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8595396 -
Flags: review?(kgrandon)
Comment 19•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8595398 -
Flags: review?(dflanagan)
Comment 20•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8595403 -
Flags: review?(dflanagan)
Comment 21•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8595406 -
Flags: review?(gaye)
Comment 22•9 years ago
|
||
Comment on attachment 8595382 [details] [review] [gaia] eliperelman:bug-1112119-dialer > mozilla-b2g:master Looks good to me
Attachment #8595382 -
Flags: review?(gsvelto) → review+
Updated•9 years ago
|
Attachment #8595380 -
Flags: review?(wilsonpage) → review+
Updated•9 years ago
|
Attachment #8595363 -
Flags: review?(kgrandon) → review+
Updated•9 years ago
|
Attachment #8595396 -
Flags: review?(kgrandon) → review+
Updated•9 years ago
|
Attachment #8595395 -
Flags: review?(kgrandon) → review+
Comment 23•9 years ago
|
||
Comment on attachment 8595394 [details] [review] [gaia] eliperelman:bug-1112119-sms > mozilla-b2g:master r=me thanks !
Attachment #8595394 -
Flags: review?(felash) → review+
Updated•9 years ago
|
Attachment #8595375 -
Flags: review?(m) → review+
Updated•9 years ago
|
Attachment #8595373 -
Flags: review?(mmedeiros) → review+
Comment 24•9 years ago
|
||
Comment on attachment 8595393 [details] [review] [gaia] eliperelman:bug-1112119-settings > mozilla-b2g:master r=me, thanks!
Attachment #8595393 -
Flags: review?(arthur.chen) → review+
Updated•9 years ago
|
Attachment #8595381 -
Flags: review?(francisco) → review+
Assignee | ||
Comment 25•9 years ago
|
||
gaia-node-modules https://github.com/mozilla-b2g/gaia-node-modules/commit/7d5ee56493f7e6192528fc1455521e757e1d4e33 Calendar https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=921b0fc5f3024026e7be71dcb8258a83a0dbb0e9 https://github.com/mozilla-b2g/gaia/commit/12a682350a139fdb472abcb62288c76f010ca35c Clock https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=5bef0f224f04e14bc968346826ac40f99d328d22 https://github.com/mozilla-b2g/gaia/commit/965b6c2580b5ff57a9a2d480252896276ee33c91 Camera https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=dcb559fd0fc2910e6ff0ed7f3c366823643bf537 https://github.com/mozilla-b2g/gaia/commit/d13332a9d72c047494b136174e2492b2f694fa44 Contacts https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=26174a8cd5cc7c128aff688ec36d1ee2295369a2 https://github.com/mozilla-b2g/gaia/commit/2422969c4d054df478c97eb715573f9ea3a70958 Dialer https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=e2f145ea8b43baf159db7f834a54fe4167c18000 https://github.com/mozilla-b2g/gaia/commit/15c7c5afcc34dfae527d51c256c65c41cdee4d08 Email https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=d493899c0a072abae5bbcab30bd226c7bbcd14a3 https://github.com/mozilla-b2g/gaia/commit/54a792d7f1440d30090f6eed6d555dc9b9d0f9af Settings https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=bbfd39b2038313fc35f93fbed65a43619795896e https://github.com/mozilla-b2g/gaia/commit/259d73decb44e1a8cc6dff05bfcce2cc9bc18db9 SMS https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=d57702712e4ab3406c337ddb4844340f0f43e5a9 https://github.com/mozilla-b2g/gaia/commit/2b37faafdaf1feb625f0ceb6cbd6be7c84ed6e34 System https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=87db92da8881f27e34f7fb6c7e03107c0f1da968 https://github.com/mozilla-b2g/gaia/commit/dcd22fb9e79e4b5d1efd3e8e9971ef8e639399f8 Homescreen https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=8c9b1691967afac6c56cbbab6256a1da00a80c6b https://github.com/mozilla-b2g/gaia/commit/9ff83208c2392331e716852a818892ff9c4cedd6
Updated•9 years ago
|
No longer blocks: PerformanceProgram
Comment 26•9 years ago
|
||
Comment on attachment 8595406 [details] [review] [gaia] eliperelman:bug-1112119-metabits > mozilla-b2g:master I like deletions more than additions! \o/
Attachment #8595406 -
Flags: review?(gaye) → review+
Comment 27•9 years ago
|
||
Comment on attachment 8595386 [details] [review] [gaia] eliperelman:bug-1112119-fmradio > mozilla-b2g:master Please rebase before you land. Bug 1155750 modified at least one of the test files, and there is now one more reference to PTH to remove (in a jshint comment)
Attachment #8595386 -
Flags: review?(dflanagan) → review+
Updated•9 years ago
|
Attachment #8595388 -
Flags: review?(dflanagan) → review+
Comment 28•9 years ago
|
||
Comment on attachment 8595391 [details] [review] [gaia] eliperelman:bug-1112119-music > mozilla-b2g:master Looks good to me, but note that the patch no longer applies cleanly. Sorry I didn't review it sooner.
Attachment #8595391 -
Flags: review?(dflanagan) → review+
Comment 29•9 years ago
|
||
Comment on attachment 8595398 [details] [review] [gaia] eliperelman:bug-1112119-video > mozilla-b2g:master r+ but note that a jshint declaration for PerformanceTestingHelper was added to video.js since you prepared this patch, so you'll need to remove that, too.
Attachment #8595398 -
Flags: review?(dflanagan) → review+
Comment 30•9 years ago
|
||
Comment on attachment 8595403 [details] [review] [gaia] eliperelman:bug-1112119-shared > mozilla-b2g:master r+ for the changes that delete the shared js file and the shared test mock, but obviously this patch can't land until all of the other patches land. The change to .jshintignore does not look right to me, however. If you're going to stop excluding those files from linting, you need to either fix them or delete them in the same patch, it seems to me.
Attachment #8595403 -
Flags: review?(dflanagan) → review+
Assignee | ||
Comment 31•9 years ago
|
||
Gallery https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=efcf58b4f4149a99d0e73fb3a14e44478298451a https://github.com/mozilla-b2g/gaia/commit/bf9f92ffbb423466e1205fecc2ab59113dfbdac6 Music https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=56de1a9aaef96e15af171dcabdf94304fca4147d https://github.com/mozilla-b2g/gaia/commit/8809812e5fc886470a4063917a4b61140311aa2f Video https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=8bf274fbbfdbd39b87dac8f5f7e4098d5b721225 https://github.com/mozilla-b2g/gaia/commit/eaba36f7e0c99e3845b286bc85ed57d54452931e
Assignee | ||
Comment 32•9 years ago
|
||
Thanks for the reviews David. I'll go ahead and move those items into the other patch that :gaye has already reviewed.
Assignee | ||
Comment 33•9 years ago
|
||
Comment on attachment 8595406 [details] [review] [gaia] eliperelman:bug-1112119-metabits > mozilla-b2g:master Carrying over :djf's review of shared files merged into this patch.
Attachment #8595406 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Attachment #8595403 -
Attachment is obsolete: true
Assignee | ||
Comment 34•9 years ago
|
||
Marina, do you think I could get a review on the cost control patch?
Flags: needinfo?(marina.rodrigueziglesias)
Comment 35•9 years ago
|
||
Comment on attachment 8595383 [details] [review] [gaia] eliperelman:bug-1112119-costcontrol > mozilla-b2g:master LGTM, sorry for delay
Flags: needinfo?(marina.rodrigueziglesias)
Attachment #8595383 -
Flags: review?(marina.rodrigueziglesias) → review+
Assignee | ||
Comment 36•9 years ago
|
||
Cost Control https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=424872a493ef497d246db77a9d8598e00b520ce6 https://github.com/mozilla-b2g/gaia/commit/f8f16cab4554dde9af2a655213e7c310bbec156c
Assignee | ||
Comment 37•9 years ago
|
||
FM Radio https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=87e8e2aed0ae580c753285557949a644088e6cb7 https://github.com/mozilla-b2g/gaia/commit/00a071d43031c0ca957032ccaeeb0eff96bde36b
Assignee | ||
Comment 38•9 years ago
|
||
Final meta-bits https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=5cbedc0748d8b2fb0e4d23c181cc52c8d7095a59 https://github.com/mozilla-b2g/gaia/commit/c16fdc3ce0c9562c2b3adc7ec7a39fb4d4bd18e6
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•