Closed
Bug 1112186
Opened 10 years ago
Closed 10 years ago
Disable building the debug RTL on Windows
Categories
(Directory :: LDAP C SDK, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jcranmer, Assigned: jcranmer)
References
Details
Attachments
(2 files, 1 obsolete file)
|
1.00 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
|
1.15 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Needed to get this working on 2013-based buildbots.
Attachment #8537286 -
Flags: review?(richm)
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8537288 -
Flags: review?(mh+mozilla)
|
||
Updated•10 years ago
|
Attachment #8537288 -
Flags: review?(mh+mozilla) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8537286 [details] [diff] [review] Patch for LDAP configure Review of attachment 8537286 [details] [diff] [review]: ----------------------------------------------------------------- Since this is urgent, I'll switch the review to glandium.
Attachment #8537286 -
Flags: review?(richm) → review?(mh+mozilla)
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8537286 [details] [diff] [review] Patch for LDAP configure Review of attachment 8537286 [details] [diff] [review]: ----------------------------------------------------------------- I think you should go with the same change as what was done for nspr: http://hg.mozilla.org/projects/nspr/diff/8175a7a0f186/configure.in That is, keep the default as it is, and make --disable-debug-rtl actually work on debug builds.
Attachment #8537286 -
Flags: review?(mh+mozilla) → feedback+
|
|
Assignee | |
Comment 4•10 years ago
|
||
So like this?
Attachment #8537286 -
Attachment is obsolete: true
Attachment #8537585 -
Flags: review?(mh+mozilla)
|
|
||
Updated•10 years ago
|
Attachment #8537585 -
Flags: review?(mh+mozilla) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
LDAP push: https://hg.mozilla.org/projects/ldap-sdks/rev/cfc95f7a6206 LDAP tag used in client.py: https://hg.mozilla.org/comm-central/rev/2522b98e9bfd comm-central configure change: https://hg.mozilla.org/comm-central/rev/4abb54b4492c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Comment 6•9 years ago
|
||
Also picked up in beta for the VS2013 update: https://hg.mozilla.org/releases/comm-beta/rev/943d4364596a
You need to log in
before you can comment on or make changes to this bug.
Description
•