fxpay: make XHR tests more readable

RESOLVED FIXED

Status

P5
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kumar, Assigned: kumar)

Tracking

Avenir
x86
Mac OS X
Points:
---

Details

(Whiteboard: [qa-])

there are many fxpay tests that do twisted async mocking so that XHR requests result in the right responses. These are hard to read and very fragile since responses can arrive out of order. Let's fix this by introducing some kind of facade object that can be mocked directly without involving XHR.
Assignee: nobody → kumar.mcmillan
Whiteboard: [qa-]

Updated

4 years ago
Priority: -- → P5
This is mostly done. I'm following a pattern like this: https://github.com/mozilla/fxpay/pull/96/files#diff-bb3f5158ace8ee2d80b4bc16a174f16aR200 It hides all the XHR mocking so that you only have to change it in one place. Hide the complexity and it goes away!
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.