Closed Bug 1112338 Opened 9 years ago Closed 9 years ago

increase max output stream to 720p

Categories

(Firefox for Android Graveyard :: Screencasting, defect)

x86
macOS
defect
Not set
normal

Tracking

(fennec36+)

RESOLVED FIXED
Firefox 37
Tracking Status
fennec 36+ ---

People

(Reporter: blassey, Assigned: blassey)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch max_1080p.patch (obsolete) — Splinter Review
      No description provided.
Attachment #8537465 - Flags: review?(mark.finkle)
When I queried the Roku's resolution, the OpenGL context only goes to 720p. This may not be an issue when doing H264 video.
Comment on attachment 8537465 [details] [diff] [review]
max_1080p.patch

>diff --git a/toolkit/modules/secondscreen/RokuApp.jsm b/toolkit/modules/secondscreen/RokuApp.jsm

>   // This code insures the generated tab mirror is not wider than 800 nor taller than 600

Change this comment too

>   // Better dimensions should be chosen after the Roku Channel is working.
>   let windowId = contentWindow.QueryInterface(Ci.nsIInterfaceRequestor).getInterface(Ci.nsIDOMWindowUtils).outerWindowID;
>   let cWidth =  Math.max(viewport.cssWidth, viewport.width);
>   let cHeight = Math.max(viewport.cssHeight, viewport.height);
> 
>-  const MAX_WIDTH = 800;
>-  const MAX_HEIGHT = 600;
>+  const MAX_WIDTH = 1920;
>+  const MAX_HEIGHT = 1080;

This is OK by me, but I would like Randall to OK it too since he has more hands on experience with the Roku side of mirroring
Attachment #8537465 - Flags: review?(rbarker)
Assignee: nobody → blassey.bugs
Comment on attachment 8537465 [details] [diff] [review]
max_1080p.patch

Review of attachment 8537465 [details] [diff] [review]:
-----------------------------------------------------------------

My only concern is the effect this will have on encode times for Android.
Attachment #8537465 - Flags: review?(rbarker) → review+
Summary: increase max output stream to 1080p → increase max output stream to 720p
Attached patch max_720p.patchSplinter Review
Attachment #8537465 - Attachment is obsolete: true
Attachment #8537465 - Flags: review?(mark.finkle)
Attachment #8538156 - Flags: review?(rbarker)
Attachment #8538156 - Flags: review?(rbarker) → review+
https://hg.mozilla.org/mozilla-central/rev/c8d145f0d0ee
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
tracking-fennec: ? → 37+
tracking-fennec: 37+ → 36+
I know I'm a little late to the party, but is there a place/bug to further the conversation about limiting output to 720p?  I didn't see any discussion here so perhaps the initial one occurred elsewhere.

Roku may be limited to 720p, but don't current (and potentially future) devices such as Matchstick and Chromecast support 1080p?

(Will OpenH264 alter the encoding conversation?)

I have a device with 1080p display, but it is newer and higher end so I'd expect encoding to be less problematic.  Not to knock experience, but do we have any data on this?  Perhaps there is a way that we can mitigate this at least in part?  Maybe offering up 1080p to known 1080p consumers or including an advanced option somewhere?  
Just brainstorming.
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: