Closed Bug 1112367 Opened 10 years ago Closed 10 years ago

EOY - Fix translation on PayPal TWD Page

Categories

(Mozilla Foundation Communications :: Website, task)

x86
macOS
task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mavis, Assigned: mavis)

Details

(Whiteboard: [EOYFR2014][donation flow][p2])

Attachments

(2 files)

58 bytes, text/x-github-pull-request
alicoding
: review+
thecount
: review+
Details | Review
64 bytes, text/plain
alicoding
: review+
Details
The strings on https://sendto.mozilla.org/page/content/paypal-donate-twd/ are in Simplified Chinese but they should really be Traditional Chinese instead. Ali, I'm marking this as P3 in case you have burning tasks on your plate. I can help do the translation and help land the changes but please direct me where I should go and tackle this.
Flags: needinfo?(ali)
1. go to Transifex page and visit Paypal resource for that language you want to fix 2. Fix the translation 3. Download the file from Transifex 4. Update them inside the repo 5. Upload to BSD Not sure if this is clear for you? Please let me know and I'm happy to help if any step is not clear.
Flags: needinfo?(ali)
Yea the steps above match what I have in mind :) Will tackle this today.
Hey Ali, could you share the link to Transifex page please. I lost it :(
Flags: needinfo?(ali)
Flags: needinfo?(ali)
Hey Ali, mind adding me to the group so I have edit rights?
Flags: needinfo?(ali)
Done @Mavis :)
Flags: needinfo?(ali)
Whiteboard: [EOYFR2014][donation flow][p3] → [EOYFR2014][donation flow][p2]
Attached file GitHub PR
Help me make sure I modified the right file :) zh-TW strings on Transifex have been updated as well.
Attachment #8539945 - Flags: review?(scott)
Attachment #8539945 - Flags: review?(ali)
Comment on attachment 8539945 [details] [review] GitHub PR I merged it but didn't build it in BSD, can do that in the morning. That gives Ali time to have a look if he wants still.
Attachment #8539945 - Flags: review?(scott) → review+
I'll land this on Tuesday morning.
Comment on attachment 8539945 [details] [review] GitHub PR r+ and I see that you have merged. But one question in there :)
Attachment #8539945 - Flags: review?(ali) → review+
Attachment #8540421 - Flags: review?(ali)
Attachment #8540421 - Flags: review?(ali) → review+
Landed!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: