1112376 - Implement memory and disk caching for favicons

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Wesley Johnston (:wesj)]

Core data already gave us disk caching really. It would be nice to have a way to create a memory cache as well. My plan here is to create a cache protocol:

protocol Cache<key, value> {
  subscript[key] -> Value
  clear()
}

and then implement it a few different ways. The easiest can be an in memory LRU cache, but we can also implement a Disk cache using core data or sqlite. I then want to wrap them in a multi-cache object

class MultiCache: Cache {
  var caches: [Cache]
}

that can iterate through the list on get, set, and clear calls.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Pull request

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

It would be nice to get some tests for the utility classes you are adding here

Comment 3

[Brian Nicholson (:bnicholson)]

Comment on attachment 8537497 [details] [review]
Pull request

Several questions/comments in the PR. Also, I think you said something about splitting this up more.

Comment 4

[Wesley Johnston (:wesj)]

We have a disk cache now. I actually want to avoid a separate memory cache if we can for now...