1112413 - mailnews/compose/src/nsMsgCompose.cpp:1476:28: error: 'class nsIScriptContext' has no member named 'GC

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

/builds/slave/tb-try-c-cen-l64-0000000000000/build/mailnews/compose/src/nsMsgCompose.cpp: In member function 'virtual nsresult nsMsgCompose::CloseWindow(bool)':
/builds/slave/tb-try-c-cen-l64-0000000000000/build/mailnews/compose/src/nsMsgCompose.cpp:1476:28: error: 'class nsIScriptContext' has no member named 'GC'
make[5]: *** [nsMsgCompose.o] Error 1

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: WIP v1

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Fix

Comment 3

[Hartmut Figge]

Either this fix or another recent checkin causes the disappearance of the bookmarks in the sidebar and the Bookmarks Manager on my SM-Trunk Linux x86_64.

Comment 4

[Joshua Cranmer [:jcranmer]]

Comment on attachment 8537581 [details] [diff] [review]
Fix

Review of attachment 8537581 [details] [diff] [review]:
-----------------------------------------------------------------

Please also remove the nsIScriptGlobalObject.h and nsIScriptContext.h imports at the top of the file.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Attachment: Fix v2

> 
> Please also remove the nsIScriptGlobalObject.h and nsIScriptContext.h
> imports at the top of the file.

Done.
Thank you so much!

Comment 6

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2014-12-16T20:28:25
log: https://treeherder.mozilla.org/ui/logviewer.html#?repo=comm-central&job_id=5215
repository: comm-central
who: hiikezoe[at]mozilla-japan[dot]org
machine: b-linux64-hp-0032
buildname: TB Linux comm-central leak test build
revision: 036deed5ab5c

/builds/slave/tb-c-cen-lx-d-0000000000000000/build/mailnews/compose/src/nsMsgCompose.cpp:1476:28: error: 'class nsIScriptContext' has no member named 'GC'
make[5]: *** [nsMsgCompose.o] Error 1
make[4]: *** [mailnews/compose/src/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 7

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2014-12-16T20:28:25
log: https://treeherder.mozilla.org/ui/logviewer.html#?repo=comm-central&job_id=5207
repository: comm-central
who: hiikezoe[at]mozilla-japan[dot]org
machine: bld-linux64-spot-454
buildname: TB Linux comm-central build
revision: 036deed5ab5c

/builds/slave/tb-c-cen-lx-000000000000000000/build/mailnews/compose/src/nsMsgCompose.cpp:1476:28: error: 'class nsIScriptContext' has no member named 'GC'
make[5]: *** [nsMsgCompose.o] Error 1
make[4]: *** [mailnews/compose/src/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 8

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2014-12-16T20:28:25
log: https://treeherder.mozilla.org/ui/logviewer.html#?repo=comm-central&job_id=5209
repository: comm-central
who: hiikezoe[at]mozilla-japan[dot]org
machine: bld-linux64-spot-046
buildname: TB Linux x86-64 comm-central leak test build
revision: 036deed5ab5c

/builds/slave/tb-c-cen-l64-d-000000000000000/build/mailnews/compose/src/nsMsgCompose.cpp:1476:28: error: 'class nsIScriptContext' has no member named 'GC'
make[5]: *** [nsMsgCompose.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 9

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2014-12-16T20:28:25
log: https://treeherder.mozilla.org/ui/logviewer.html#?repo=comm-central&job_id=5208
repository: comm-central
who: hiikezoe[at]mozilla-japan[dot]org
machine: bld-linux64-spot-066
buildname: TB Linux x86-64 comm-central build
revision: 036deed5ab5c

/builds/slave/tb-c-cen-l64-00000000000000000/build/mailnews/compose/src/nsMsgCompose.cpp:1476:28: error: 'class nsIScriptContext' has no member named 'GC'
make[5]: *** [nsMsgCompose.o] Error 1
make[4]: *** [mailnews/compose/src/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 10

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2014-12-16T20:28:25
log: https://treeherder.mozilla.org/ui/logviewer.html#?repo=comm-central&job_id=5212
repository: comm-central
who: hiikezoe[at]mozilla-japan[dot]org
machine: bld-lion-r5-075
buildname: TB OS X 10.7 comm-central build
revision: 036deed5ab5c

/builds/slave/tb-c-cen-osx64-000000000000000/build/mailnews/compose/src/nsMsgCompose.cpp:1476:28: error: no member named 'GC' in 'nsIScriptContext'
make[6]: *** [nsMsgCompose.o] Error 1
make[5]: *** [mailnews/compose/src/target] Error 2
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [compile] Error 2
make[3]: *** [default] Error 2
make[2]: *** [build] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 11

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2014-12-16T20:28:25
log: https://treeherder.mozilla.org/ui/logviewer.html#?repo=comm-central&job_id=5214
repository: comm-central
who: hiikezoe[at]mozilla-japan[dot]org
machine: bld-lion-r5-011
buildname: TB OS X 10.7 64-bit comm-central leak test build
revision: 036deed5ab5c

/builds/slave/tb-c-cen-osx64-d-0000000000000/build/mailnews/compose/src/nsMsgCompose.cpp:1476:28: error: no member named 'GC' in 'nsIScriptContext'
make[5]: *** [nsMsgCompose.o] Error 1
make[4]: *** [mailnews/compose/src/target] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [compile] Error 2
make[2]: *** [default] Error 2
make[1]: *** [build] Error 2
make: *** [build] Error 2

Comment 12

[Joshua Cranmer [:jcranmer]]

https://hg.mozilla.org/comm-central/rev/d655acbc5efe

Comment 13

[Kent James (:rkent)]

This change causes nsMsgCompose.cpp to fail with external linkage, presumably because PokeGC is not exported.

Are we sure we really need this at all?

Comment 14

[Kent James (:rkent)]

And by "do we need this" I mean maybe we can get rid of the call to PokeGC completely.