mailnews/compose/src/nsMsgCompose.cpp:1476:28: error: 'class nsIScriptContext' has no member named 'GC

RESOLVED FIXED in Thunderbird 37.0

Status

defect
--
critical
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: hiro, Assigned: hiro)

Tracking

({dogfood, regression})

unspecified
Thunderbird 37.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

/builds/slave/tb-try-c-cen-l64-0000000000000/build/mailnews/compose/src/nsMsgCompose.cpp: In member function 'virtual nsresult nsMsgCompose::CloseWindow(bool)':
/builds/slave/tb-try-c-cen-l64-0000000000000/build/mailnews/compose/src/nsMsgCompose.cpp:1476:28: error: 'class nsIScriptContext' has no member named 'GC'
make[5]: *** [nsMsgCompose.o] Error 1
Posted patch WIP v1 (obsolete) — Splinter Review
Posted patch Fix (obsolete) — Splinter Review
Attachment #8537554 - Attachment is obsolete: true
Either this fix or another recent checkin causes the disappearance of the bookmarks in the sidebar and the Bookmarks Manager on my SM-Trunk Linux x86_64.
Attachment #8537581 - Flags: review?(Pidgeot18)
Comment on attachment 8537581 [details] [diff] [review]
Fix

Review of attachment 8537581 [details] [diff] [review]:
-----------------------------------------------------------------

Please also remove the nsIScriptGlobalObject.h and nsIScriptContext.h imports at the top of the file.
Attachment #8537581 - Flags: review?(Pidgeot18) → review+
Posted patch Fix v2Splinter Review
> 
> Please also remove the nsIScriptGlobalObject.h and nsIScriptContext.h
> imports at the top of the file.

Done.
Thank you so much!
Assignee: nobody → hiikezoe
Attachment #8537581 - Attachment is obsolete: true
Attachment #8537610 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/d655acbc5efe
Status: NEW → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 37.0
This change causes nsMsgCompose.cpp to fail with external linkage, presumably because PokeGC is not exported.

Are we sure we really need this at all?
And by "do we need this" I mean maybe we can get rid of the call to PokeGC completely.
Depends on: 1114686
You need to log in before you can comment on or make changes to this bug.