1112436 - makedocs.pl is spewing cronmail on every run, even if successful

Status: RESOLVED FIXED

(Bugzilla :: bugzilla.org, defect)

Description

[Dave Miller [:justdave]]

Every cron run building the website is producing the following output:

Already on 'master'
Already on '4.2'
Already on '5.0'
Already on '4.0'
Already on '4.4'

(regression from bug 1108076)

Comment 1

[Dave Miller [:justdave]]

Attachment: Patch v1

13:17:45 <gerv> Simply replacing system with backticks should do it.

And so we have.

Comment 2

[Dave Miller [:justdave]]

Already in production.

Checking in bin/build-docs.pl;
/www/bugzilla-org/bin/build-docs.pl,v  <--  build-docs.pl
new revision: 1.15; previous revision: 1.14
done

Comment 3

[:glob ✱]

(In reply to Dave Miller [:justdave] ([e-mail]) from comment #1)
> 13:17:45 <gerv> Simply replacing system with backticks should do it.

yes, but that's a hack - you're telling perl do a lot of extra work to capture the output of the command and then throwing it away.

a better fix is: 
> system("git checkout -q " . $branches{$version});

Comment 4

[Dave Miller [:justdave]]

Attachment: Patch v2

Better fix, suggested by glob.  Tested and works.

Comment 5

[Dave Miller [:justdave]]

Checking in bin/build-docs.pl;
/www/bugzilla-org/bin/build-docs.pl,v  <--  build-docs.pl
new revision: 1.16; previous revision: 1.15
done

And this lets us still get the output in the cron mail if something does go wrong, too.