Closed
Bug 1112476
Opened 9 years ago
Closed 9 years ago
Support dumping texture data on the ClientLayerManager
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: BenWa, Assigned: BenWa)
References
Details
Attachments
(1 file, 2 obsolete files)
24.21 KB,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8537645 -
Flags: review?(mstange)
Assignee | ||
Updated•9 years ago
|
Attachment #8537645 -
Attachment is patch: true
Comment 1•9 years ago
|
||
Comment on attachment 8537645 [details] [diff] [review] Add support for a subset of TextureClient Review of attachment 8537645 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/layers/client/TextureClient.cpp @@ +572,5 @@ > +void > +TextureClient::PrintInfo(std::stringstream& aStream, const char* aPrefix) > +{ > + aStream << aPrefix; > + aStream << nsPrintfCString("TextureClient (0x%p)", this).get(); My compiler complains about nsPrintfCString not being defined, you're likely missing an include.
Comment 2•9 years ago
|
||
Comment on attachment 8537645 [details] [diff] [review] Add support for a subset of TextureClient Review of attachment 8537645 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/layers/client/TextureClient.cpp @@ +572,5 @@ > +void > +TextureClient::PrintInfo(std::stringstream& aStream, const char* aPrefix) > +{ > + aStream << aPrefix; > + aStream << nsPrintfCString("TextureClient (0x%p)", this).get(); Three of them: #include "nsPrintfCString.h" // for nsPrintfCString #include "LayersLogging.h" // for AppendToString #include "gfxUtils.h" // for gfxUtils::GetAsLZ4Base64Str
Comment 3•9 years ago
|
||
Comment on attachment 8537645 [details] [diff] [review] Add support for a subset of TextureClient Review of attachment 8537645 [details] [diff] [review]: ----------------------------------------------------------------- Is it just me or is TiledLayerBuffer<Derived, Tile>::Dump looking unnecessarily complicated? Anyway, you're just moving that code, no need to change it here.
Attachment #8537645 -
Flags: review?(mstange) → review+
Assignee | ||
Comment 4•9 years ago
|
||
We could make it easier if we had a better iterator, but we don't iterate over it much.
Comment 5•9 years ago
|
||
The thing that stood out to me was the adjustment of w / h at the end of the loop, which seems really unnecessary, since the adjusted value isn't really used except for indicating that the loop has ended, and that would be the case without the adjustment, too.
Assignee | ||
Comment 6•9 years ago
|
||
You're right, I can remove that.
Assignee | ||
Comment 7•9 years ago
|
||
Assignee: nobody → bgirard
Attachment #8537645 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8538545 -
Flags: review+
Assignee | ||
Comment 8•9 years ago
|
||
+ Missing include on some platforms.
Attachment #8538545 -
Attachment is obsolete: true
Attachment #8538617 -
Flags: review+
Assignee | ||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a7684665cab
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5a7684665cab
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•