Closed Bug 1112476 Opened 5 years ago Closed 5 years ago

Support dumping texture data on the ClientLayerManager

Categories

(Core :: Graphics: Layers, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: BenWa, Assigned: BenWa)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Attachment #8537645 - Flags: review?(mstange)
Attachment #8537645 - Attachment is patch: true
Comment on attachment 8537645 [details] [diff] [review]
Add support for a subset of TextureClient

Review of attachment 8537645 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/client/TextureClient.cpp
@@ +572,5 @@
> +void
> +TextureClient::PrintInfo(std::stringstream& aStream, const char* aPrefix)
> +{
> +  aStream << aPrefix;
> +  aStream << nsPrintfCString("TextureClient (0x%p)", this).get();

My compiler complains about nsPrintfCString not being defined, you're likely missing an include.
Comment on attachment 8537645 [details] [diff] [review]
Add support for a subset of TextureClient

Review of attachment 8537645 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/client/TextureClient.cpp
@@ +572,5 @@
> +void
> +TextureClient::PrintInfo(std::stringstream& aStream, const char* aPrefix)
> +{
> +  aStream << aPrefix;
> +  aStream << nsPrintfCString("TextureClient (0x%p)", this).get();

Three of them:

#include "nsPrintfCString.h"            // for nsPrintfCString
#include "LayersLogging.h"              // for AppendToString
#include "gfxUtils.h"                   // for gfxUtils::GetAsLZ4Base64Str
Blocks: 1112718
Comment on attachment 8537645 [details] [diff] [review]
Add support for a subset of TextureClient

Review of attachment 8537645 [details] [diff] [review]:
-----------------------------------------------------------------

Is it just me or is TiledLayerBuffer<Derived, Tile>::Dump looking unnecessarily complicated? Anyway, you're just moving that code, no need to change it here.
Attachment #8537645 - Flags: review?(mstange) → review+
We could make it easier if we had a better iterator, but we don't iterate over it much.
The thing that stood out to me was the adjustment of w / h at the end of the loop, which seems really unnecessary, since the adjusted value isn't really used except for indicating that the loop has ended, and that would be the case without the adjustment, too.
You're right, I can remove that.
Assignee: nobody → bgirard
Attachment #8537645 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8538545 - Flags: review+
+ Missing include on some platforms.
Attachment #8538545 - Attachment is obsolete: true
Attachment #8538617 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/5a7684665cab
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.