display list dump should print the layer offset

RESOLVED FIXED in mozilla37

Status

()

Core
Layout
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: BenWa, Assigned: BenWa)

Tracking

(Blocks: 1 bug)

unspecified
mozilla37
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Created attachment 8537657 [details] [diff] [review]
patch
Attachment #8537657 - Flags: review?(matt.woodrow)
(Assignee)

Updated

3 years ago
Assignee: nobody → bgirard
(Assignee)

Updated

3 years ago
Blocks: 1112718
Comment on attachment 8537657 [details] [diff] [review]
patch

Review of attachment 8537657 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/nsLayoutDebugger.cpp
@@ +149,5 @@
>  #endif
>    bool snap;
>    nsRect rect = aItem->GetBounds(aBuilder, &snap);
> +  nsRect layerRect = rect + aItem->ReferenceFrame()->GetOffsetToCrossDoc(
> +    nsLayoutUtils::GetAnimatedGeometryRootFor(aItem, aBuilder, nullptr));

I think it'd be clearer to do animatedGeometryRoot->GetOffsetToCrossDoc(referenceFrame), and subtract the result instead of adding it.
Attachment #8537657 - Flags: review?(matt.woodrow) → review+
(Assignee)

Comment 2

3 years ago
Created attachment 8538566 [details] [diff] [review]
Add the layer bounds in the DisplayList dump. r=mattwoodrow
Attachment #8537657 - Attachment is obsolete: true
Attachment #8538566 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/7ddd8f21f0a2
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.