Review Revision page should contain revision comments for all locales

RESOLVED FIXED in Future

Status

support.mozilla.org
Knowledge Base Software
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: atopal, Assigned: pollti)

Tracking

unspecified
Future

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: u=contributor c=wiki p= s=2013.backlog)

Attachments

(1 attachment, 1 obsolete attachment)

44 bytes, text/x-github-pull-request
Details | Review | Splinter Review
(Reporter)

Description

4 years ago
Bug 696658 started showing the revision comment on the review page, but it's only shown for English, we'd need that for localized articles as well. Also, it only shows the comment of the revision being reviewed, we need previous comments as well until the revision marked "current".

Here is how it should look like: http://note.io/1qkVZ9b
Topal, So need to be done 2 things
# Show Revision Comment in the Review page of All Locals
# Show Previous Revision Comment

In your Screenshot, I am seeing same 2 comments of same Revision 67751. Can you please provide a simple STR for the 2nd one? So it will be clear!
Flags: needinfo?(a.topal)
(Reporter)

Comment 2

4 years ago
Hey Safwan, the text is the same because I was lazy, those would be different revisions.
Flags: needinfo?(a.topal)
:D Topal, thanks for the Information. So I think according to the Bug Title, this below things need to be done
# Show Previous Revision Comment in the Review page of All Locals

So the STR should be as following:
# Create a Article and approve it.
# Make an Edit/Revision and "dont" approve it.(Regard this Revision number is "1100")
# Make Another Revision and go to Review page of the Revision.(Regard this Revision number is "2244")
Actual Result:
# You can only see the comment of the "Revision: 2244")
Expected Result
# You should also see the comment of "Revision:1100"

Topal, Is the STR right? ;)

And regarding the "#Show Revision Comment in the Review page of All Locals", Can you please open another bug for that? so we can track that on there!
Flags: needinfo?(a.topal)
(Assignee)

Comment 4

3 years ago
Created attachment 8580088 [details] [review]
add bug 696658's feature for locales

This adds bug 696658's feature for all locales. A feature to show all comments should still be added.
(Assignee)

Comment 5

3 years ago
Created attachment 8583184 [details] [review]
add bug 696658's feature for locales
Attachment #8580088 - Attachment is obsolete: true
I deployed https://github.com/mozilla/kitsune/commit/3703fae461d574658166c8848c9e809d3073c086 to prod.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 7

3 years ago
Thanks, mythmon! However, it's only the first part of this bug. The other revison comments should still be added to the review page.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Pollti, I think we should open another bug for tracking that!
I am changing this Bug description and closing it!
Thanks a lot for your contribution
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
Summary: Review Revision page should contain current and previous revision comments for all locales → Review Revision page should contain revision comments for all locales
Pollti, Here I filled another Bug 1150014.
See Also: → bug 1150014
(Assignee)

Comment 10

3 years ago
Thanks, safwan! Maybe I'll find the time to take bug 1150014 in the future.
Assignee: nobody → pollti
Flags: needinfo?(a.topal)
You need to log in before you can comment on or make changes to this bug.