hg pushes should not be able to create corrupt entries in change_properties.property_value of buildbot_schedulers database

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: pmoore, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
In bug 1112456 we had a situation where a particular hg push was able to block all tests from running across all trees due to it creating a truncated entry in change_properties.property_value of buildbot_schedulers database.

Our buildbot code should not allow such an entry to enter the database.
I pushed >7000 changesets to Try today in small batches so I would avoid this bug. I think it worked. I don't plan on making any large Try pushes any time soon. Hopefully you don't have to worry about anyone triggering this for a while :)
Created attachment 8566933 [details] [diff] [review]
take into account json overhead
Attachment #8566933 - Flags: review?
Comment on attachment 8566933 [details] [diff] [review]
take into account json overhead

Review of attachment 8566933 [details] [diff] [review]:
-----------------------------------------------------------------

<hack stamp>
Attachment #8566933 - Flags: review? → review+
Attachment #8566933 - Flags: checked-in+
hopefully this sticks
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Component: Tools → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.