Settings unit test failing from performance.mark being undefined

RESOLVED WONTFIX

Status

Firefox OS
Gaia::PerformanceTest
RESOLVED WONTFIX
3 years ago
3 years ago

People

(Reporter: Eli, Assigned: Eli)

Tracking

({perf})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
In bug 1088118 I committed a change to Settings to add new performance markers, but during the process Settings had been refactored and my rebased patch now causes unit tests to fail with window.performance.mark being undefined.
(Assignee)

Comment 1

3 years ago
Created attachment 8537906 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26854

Looks like the Settings refactoring changed the need for the user timing shim, so I have added it to this test to keep it from failing.
Attachment #8537906 - Flags: review?(arthur.chen)
(Assignee)

Comment 2

3 years ago
Going to move this review back to bug 1088118 since that PR will have a smaller surface area.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
Comment on attachment 8537906 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26854

Cancel the request per comment 2.
Attachment #8537906 - Flags: review?(arthur.chen)
You need to log in before you can comment on or make changes to this bug.