46 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
In bug 1088118 I committed a change to Settings to add new performance markers, but during the process Settings had been refactored and my rebased patch now causes unit tests to fail with window.performance.mark being undefined.
Created attachment 8537906 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26854 Looks like the Settings refactoring changed the need for the user timing shim, so I have added it to this test to keep it from failing.
Going to move this review back to bug 1088118 since that PR will have a smaller surface area.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
Comment on attachment 8537906 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26854 Cancel the request per comment 2.
You need to log in before you can comment on or make changes to this bug.