Closed Bug 111264 Opened 23 years ago Closed 23 years ago

nsTextFrame::SetSelected() calls Invalidate() with empty rect.

Categories

(Core :: DOM: Selection, defect, P3)

defect

Tracking

()

VERIFIED FIXED
mozilla0.9.7

People

(Reporter: kinmoz, Assigned: kinmoz)

References

()

Details

(Whiteboard: fixed on trunk)

Attachments

(1 file)

In my debug builds, I'm seeing lots of warning messages in my console coming 
from nsFrame::Invalidate():

    NS_WARNING("empty damage rect: update caller to avoid fcn call overhead");

whenever I select text on pages like http://www.mozilla.org. These messages are 
really bogging down selection speed in debug builds.

The invalidate calls are from nsTextFrame::SetSelected(), and the text frames in 
question seem to be related to the HTML whitespace formatting nodes ... they 
don't actually render on screen, but they are in the frame tree with zero width 
and height, and get their SELECT bits set during selection manipulation.

I have a patch that modifies SetSelected() to check if the rect is empty before 
calling Invalidate().
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla0.9.7
Attached patch Patch Rev 1Splinter Review
Can I get an r= and sr= from mjudge and attinasi for Patch Rev 1?
Whiteboard: FIX IN HAND, need r= and sr=
Comment on attachment 58738 [details] [diff] [review]
Patch Rev 1

r=jfrancis@netscape.com
Attachment #58738 - Flags: review+
Comment on attachment 58738 [details] [diff] [review]
Patch Rev 1

sr=attinasi - alright! That warning really worked - sorry I didn't catcth that
case earlier.
Attachment #58738 - Flags: superreview+
Whiteboard: FIX IN HAND, need r= and sr= → FIX IN HAND, ready for checkin
Fix checked in on TRUNK:

    mozilla/layout/html/base/src/nsTextFrame.cpp  revision 1.339
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Whiteboard: FIX IN HAND, ready for checkin → fixed on trunk
Verified fix checked into lxr.mozilla.org
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: