1112652 - Make the push date/time more obviously a permalink

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P4)

Description

[Armen [:armenzg]]

I currently have to handcraft the URL by appending &revision=

I also noticed that you could click on the time date and it will open in a new tab which I could copy/paste.

Could we add a small icon to the date to indicate that allows the sharing?
Or something to make it clear that it will open up on a new tab?

Comment 1

[Ed Morley [:emorley]]

WFM by doing:

Date timestamp -> context menu -> copy link location

We previously had a flash plugin "copy to clipboard", but I don't like flash, and until the clipboard API actually allows us to do that, we don't really have any other choice. Is this just a discoverability thing? Do you think we should just have a permalink icon or something?

(The open in a new tab is not ideal, we should change that (bug 1077554 is open for this).)

Comment 2

[Armen [:armenzg]]

Discoverability is the main thing.
Now that I know I won't have an issue.

Comment 3

[Armen [:armenzg]]

If we remove the new tab opening, would I still be able to copy the URL from the address bar?

Comment 4

[Ed Morley [:emorley]]

(In reply to Armen Zambrano - Automation & Tools Engineer (:armenzg) from comment #2)
> Discoverability is the main thing.
> Now that I know I won't have an issue.

Cool - will adjust summary accordingly :-)

(In reply to Armen Zambrano - Automation & Tools Engineer (:armenzg) from comment #3)
> If we remove the new tab opening, would I still be able to copy the URL from
> the address bar?

Yeah it would just be removing the target=_blank

Comment 5

[Jonathan French (:jfrench)]

(In reply to Armen Zambrano - Automation & Tools Engineer (:armenzg) from comment #2)
> Discoverability is the main thing.
> Now that I know I won't have an issue.

We do have a hover title for discoverability that says "open this resultset". But if we can improve upon that wording let us know and we can tweak it. eg. "open this resultset url" or something else.

If you have to do this many many times a day, we could also consider the copy-hover directive we have for the Logviewer icon (allows you to ctrl+c while hovering over the icon), but this seems overkill given the resultset date/time is already being drawn as a link.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Could we add some icon to the left of the timestamp to make it more obvious that it's a link?

Possibly http://fortawesome.github.io/Font-Awesome/icon/link/ ?

Comment 7

[Armen [:armenzg]]

I think what Wes suggests might be good enough.

Comment 8

[Jonathan French (:jfrench)]

Sorry I must have misunderstood what piece of ui you guys are referring to. If you can include a screen grab of it, that would be helpful.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: screenshot.png

I was under the impression we're talking about this timestamp.

Comment 10

[Jonathan French (:jfrench)]

Ok, that's what I thought we were talking about also.

Then I'm confused why its appearance as a link (blue which becomes purple when visited, underlines on hover, pointer switches on hover) isn't sufficient to communicate it is a link.

ie. it's consistent with all the other links on the platform.

We could update its title to "Open this resultset and url" or whatever, if that helps.

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I think it's just that it's not super clear that it's a permalink to that specific push. TBPL wasn't any better at discoverability, but we can probably do better. 

Maybe rearranging the items in the row so the order goes [timestamp link, cset revision text, pusher email link] would help, so there's a non-link item between the two links, so there's some color differentiation?

Comment 12

[Jonathan French (:jfrench)]

I've wordsmithed the tooltip this week locally about 5-6x, and have a wording that (I think) will be a lot more clear and discoverable that it's a permalink. Err.. hopefully :) I'll put it up as a supplementary PR, plus some other earlier attempts in the PR description for reference.

Wrt to adding icons, my understanding is there's a general mandate to de-clutter the UI (an ongoing concern by TBPL users, sheriffs and others) so I think we'd like to avoid adding icons here and elsewhere (ie. to be consistent) indicating links beyond what we already do with color, hover behavior, styling, and tooltip. Just my take.. but that's my understanding.

nb. camd did some of that resultset bar de-cluttering with his recent work in PR354 last month. I think there was consensus at that time to leave the resultset bar SHA positioned where it is at present. If there is broad consensus to move it in between the build date link and author filter link replacing the current " - " divider, sure we could do that. Iirc some users prefer the current position from feedback in channel, as it is easily copyable because it is not in proximity to anything else.

I'm not against it but think we just need to be mindful with relocations, without consistent complaints coming in from many users on a UI position. With more and more users on the platform, it just becomes harder to anticipate everyone's workflow idiosyncrasies and not introduce papercuts.

Comment 13

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#437-supplemental

Supplemental PR in case this sufficiently addresses the use problem.

Comment 14

[Jonathan French (:jfrench)]

We iterated in the PR and added a nice UI element in addition to the message. So I think we are good to go, pending review.

Comment 15

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/52e4c2f5165927e4a1bba8861e5390c604867753
Bug 1112652 -  Communicate the resultset date link is a permalink/url

https://github.com/mozilla/treeherder-ui/commit/89031029475d39f636e2408ea6d46d60f4d2630c
Merge pull request #437 from tojonmz/open-resultset-link

Bug 1112652 -  Communicate the resultset date link is a permalink/url

Comment 16

[William Lachance (:wlach)]

Comment on attachment 8581164 [details] [review]
treeherder-ui-PR#437-supplemental

Awesome, thanks!

Comment 17

[Jonathan French (:jfrench)]

Thanks wlach :) Marking fixed per above merge.

Comment 18

[Jonathan French (:jfrench)]

Verified fixed on production.

Comment 19

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/e011297ddf26e1d08601fc43c256ec4718b67ccf
Bug 1112652 -  Communicate the resultset date link is a permalink/url

https://github.com/mozilla/treeherder/commit/6668b1e6f0004e46222926bcd2e92633270366f8
Merge pull request #437 from tojonmz/open-resultset-link

Bug 1112652 -  Communicate the resultset date link is a permalink/url