B2GDesktopInstance overrides GeckoInstance.required_prefs

RESOLVED FIXED in mozilla38

Status

Testing
Marionette
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ted, Assigned: ted)

Tracking

({ateam-marionette-client})

unspecified
mozilla38
ateam-marionette-client
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
I suspect this is an accident:
http://hg.mozilla.org/mozilla-central/annotate/cb8ad2251c09/testing/marionette/client/marionette/geckoinstance.py#l139

That class attribute overrides GeckoInstance.required_prefs, which doesn't seem like what it ought to do.
(Assignee)

Comment 1

3 years ago
Created attachment 8540716 [details] [diff] [review]
Fix B2GDesktopInstance.required_prefs

This seems to do the trick.
Attachment #8540716 - Flags: review?(ahalberstadt)
(Assignee)

Updated

3 years ago
Assignee: nobody → ted
Status: NEW → ASSIGNED
Attachment #8540716 - Flags: review?(ahalberstadt) → review+
Keywords: ateam-marionette-client
(Assignee)

Comment 2

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1476b32400da
https://hg.mozilla.org/mozilla-central/rev/1476b32400da
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.