1112679 - Update BROWSERID_AUDIENCES in local.py-dist

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: One and Done, defect, P5)

Description

[Rebecca Billings [:rbillings]]

It would be helpful to add this to the readme file:

Access the site via http://127.0.0.1:8000/, nothttp://localhost:8000, 

add to local.py:

BROWSERID_AUDIENCES = ['http://localhost:8000', 'http://127.0.0.1:8000']

Comment 1

[Anmol Garg]

Hi Rebecca,

I would like to help fixing this bug. Could you give me a headstart?

Thanks!

Comment 2

[Rebecca Billings [:rbillings]]

Hi! The first step is getting One and Done running locally. You can follow the steps here: https://developer.mozilla.org/en-US/docs/Mozilla/QA/Running_Web_QA_automated_tests

Here is the repo: https://github.com/mozilla/oneanddone

Then all you need to do is edit the readme file and submit a pull request.

Comment 3

[Anmol Garg]

Hi Rebecca, 

In which section should I add the line "Access the site via http://127.0.0.1:8000/, not http://localhost:8000" in the readme file?

Thanks

Comment 4

[Rebecca Billings [:rbillings]]

Please add it to the top of the section called "Running Unit Tests".

Comment 5

[Giovanny Gongora [:gioyik]]

Attachment: Github PR

It's a pull request with the changes required.

Comment 6

[Rebecca Billings [:rbillings]]

Comment on attachment 8546090 [details] [review]
Github PR

Reviewed, waiting on one more for a merge.

Comment 7

[Bob Silverberg [:bsilverberg]]

Looking at this now, I think a better solution would be to change `local.py-dist` in the settings folder to specify:

BROWSERID_AUDIENCES = ['http://localhost:8000', 'http://127.0.0.1:8000']

instead of:

BROWSERID_AUDIENCES = ['http://localhost:8000']

That would allow the site to be accessed by either host.

I will also comment on the pull request.

Comment 8

[Bob Silverberg [:bsilverberg]]

Commits pushed to master at https://github.com/mozilla/oneanddone

https://github.com/mozilla/oneanddone/commit/785a5ab749a4425708d5808c1f67b8a95d5ca296
Bug 1112679 - Add local host info to the readme file

https://github.com/mozilla/oneanddone/commit/333ba2626b19c3a6c57db47cdc933bcc35111062
Merge pull request #241 from Gioyik/patch-1

Bug 1112679 - Add local host info to the readme file

Comment 9

[Rebecca Billings [:rbillings]]

Verified