Closed Bug 1112688 Opened 5 years ago Closed 5 years ago

Height of Search pane preferences window too small in some localizations, pushing "Add more search engines" off screen

Categories

(Firefox :: Preferences, defect)

35 Branch
x86_64
Windows 8.1
defect
Not set
Points:
2

Tracking

()

VERIFIED FIXED
Firefox 37
Iteration:
37.2
Tracking Status
firefox35 --- verified
firefox36 --- verified
firefox37 --- verified

People

(Reporter: aryx, Assigned: florian)

References

Details

Attachments

(1 file)

Firefox 35.0b4 on Windows 8.1, Windows 7, OS X 10.10

Opening the search preferences from the search bar pushes "Add more search engines" mostly off screen if the two labels wrap.

I adjusted the prefMinSize.* preference on Windows to fix this: http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/preferences/preferences.dtd#10
But testing on all versions and font size and themes seems error prone.

According to flod and flo, it doesn't seem to be used on Mac at all.
In en-US one of the two labels already wraps; and I have a style="margin-bottom: 1em" at http://mxr.mozilla.org/mozilla-central/source/browser/components/preferences/search.xul#55 to work around it.

That hack was meant to be 'until someone finds a real solution'. If nobody finds a better idea, I guess we could just make that 2em so that both labels can wrap without hiding the link away.

But the hack is ugly on Windows, as the bottom border of the groupbox is hidden anyway.
Attached patch PatchSplinter Review
> I guess we could just make that 2em so that both labels
> can wrap without hiding the link away.

2em or 2.5em isn't enough. Things start looking good when both labels wrap with 3em.

> But the hack is ugly on Windows, as the bottom border of the groupbox is
> hidden anyway.

That's easy to fix, I just moved the margin-bottom from the hbox to the groupbox.
Assignee: nobody → florian
Status: NEW → ASSIGNED
Attachment #8540041 - Flags: review?(felipc)
Note that this is still not a real fix; just a way to make the UI look good in 35. If some locales have a string that needs 3 lines (seems unlikely to me), they will still have the problem.
Points: --- → 2
Flags: qe-verify+
Flags: firefox-backlog+
Comment on attachment 8540041 [details] [diff] [review]
Patch

Review of attachment 8540041 [details] [diff] [review]:
-----------------------------------------------------------------

Is there a bug on file about having a shared CSS file for the prefs? If not, can you file one, please?
Attachment #8540041 - Flags: review?(felipc) → review+
https://hg.mozilla.org/integration/fx-team/rev/f37d5d147f3f

> Is there a bug on file about having a shared CSS file for the prefs? If not,
> can you file one, please?

It's shared for the in-content version (that doesn't suffer from this bug) http://mxr.mozilla.org/mozilla-central/source/browser/themes/shared/incontentprefs/search.css

I haven't seen any CSS file in the shared themes folder that is used for the old preferences dialog, so I assumed it's something we are not interested in doing at this point. If you disagree I can file the bug :-).
Comment on attachment 8540041 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: bug 1107278 (shipping the new searchbar UI localized in 35).
[User impact if declined]: On localized builds the bottom of the search preference pane may be hidden.
[Describe test coverage new/current, TBPL]: only tested locally, QA will verify.
[Risks and why]: low risk hack: just adding a bottom margin.
[String/UUID change made/needed]: none.
Attachment #8540041 - Flags: approval-mozilla-beta?
Attachment #8540041 - Flags: approval-mozilla-aurora?
Comment on attachment 8540041 [details] [diff] [review]
Patch

Since we only have one Beta this week, approving now (before it's been landed to central) so it can get uplift to beta branch and have more time with users.
Attachment #8540041 - Flags: approval-mozilla-beta?
Attachment #8540041 - Flags: approval-mozilla-beta+
Attachment #8540041 - Flags: approval-mozilla-aurora?
Attachment #8540041 - Flags: approval-mozilla-aurora+
Iteration: --- → 37.2
https://hg.mozilla.org/mozilla-central/rev/f37d5d147f3f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Verified fixed on Windows 7 64bit, Windows 8.1 64 bit and Mac OSX 10.9.5 using latest Nightly 37.0a1 (buildID: 20141229030217) and latest Aurora 36.0a2 (buildID: 20141229004004) - localized builds: en-US, de, es-ES, fr, it, ja. 

I will verify the bug on Firefox 35 Beta 8 and I will change the STATUS afterwards.
Verified fixed on Firefox 35 Beta 8 (buildID: 20141229214612): the "Add more search engines" is correctly displayed into the preferences window (when open it from the search bar).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.