1112711 - Artists subview list doesn't indicate the albums

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Hubert Figuiere [:hub]]

Attachment: Screenshot showing the problem

Got to artist view.

Tap on an artist that has several albums

You have a list of tracks, grouped by album.
But no indication of the album
The displayed art is the one for the first album displayed.

Expected:
Clear indication of the album title and matching art.

Comment 2

[Hubert Figuiere [:hub]]

There is a two level design in the new Visual design of the music app. Need to consider for this.

Comment 3

[Hubert Figuiere [:hub]]

This is still valid for NGA.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] hfiguiere:bug1112711-albums > mozilla-b2g:master

Comment 5

[Hubert Figuiere [:hub]]

Comment on attachment 8671972 [details] [review]
[gaia] hfiguiere:bug1112711-albums > mozilla-b2g:master

I have no idea how to make the section look like in the artists view. Otherwise it works.

Comment 6

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8671972 [details] [review]
[gaia] hfiguiere:bug1112711-albums > mozilla-b2g:master

LGTM. To get the sections to appear correctly, the view needs to include gaia-sub-header.js like this:

https://github.com/mozilla-b2g/gaia/blob/master/apps/music/views/artists/index.html#L24

Comment 7

[Hubert Figuiere [:hub]]

Comment on attachment 8671972 [details] [review]
[gaia] hfiguiere:bug1112711-albums > mozilla-b2g:master

This version now works.

I use the "toLowerCase()" to normalize the title as the section show them in all cases - this also solves the case where there are case discrepencies amongst the files on the same album.

Ideally we'd have a way to set the text label of the section independently of its key.

Also it would be nice if the "artist-detail" view showed the artist name. :-/

Comment 8

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8671972 [details] [review]
[gaia] hfiguiere:bug1112711-albums > mozilla-b2g:master

Only comment I have is that I'm not sure we need to lower-case the album name since we're not using the picker.

Comment 9

[Hubert Figuiere [:hub]]

The lowercase isn't about the picker. But then I'll remove it as I believe it might have side effects with not latin locales.

Comment 10

[Hubert Figuiere [:hub]]

Merged
https://github.com/mozilla-b2g/gaia/commit/26f3d0e450c19611be8a026d5b896691bacd3a1e