Closed Bug 1112715 Opened 5 years ago Closed 5 years ago

--tab-hover-color variable in devedition theme causes "Property contained reference to invalid variable. Error in parsing value for 'color'. Falling back to 'inherit'."

Categories

(Firefox :: Theme, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 37

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

(Whiteboard: [devedition-polish])

Attachments

(1 file, 2 obsolete files)

Attached patch undefined-var.patch (obsolete) — Splinter Review
This was a typo / oversight on my part
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8539503 - Flags: review?(gijskruitbosch+bugs)
Attached patch undefined-var.patch (obsolete) — Splinter Review
Instead just removing the variable reference as discussed on IRC.  The color change isn't that obvious anyway so going to remove CSS instead of adding it.
Attachment #8539503 - Attachment is obsolete: true
Attachment #8539503 - Flags: review?(gijskruitbosch+bugs)
Attachment #8539514 - Flags: review?(gijskruitbosch+bugs)
Whiteboard: [devedition-polish]
Comment on attachment 8539514 [details] [diff] [review]
undefined-var.patch

Review of attachment 8539514 [details] [diff] [review]:
-----------------------------------------------------------------

r+ assuming you've checked we don't end up losing a specificity fight somewhere and then use the default theme's hover color: .
Attachment #8539514 - Flags: review?(gijskruitbosch+bugs) → review+
(In reply to :Gijs Kruitbosch from comment #3)
> Comment on attachment 8539514 [details] [diff] [review]
> undefined-var.patch
> 
> Review of attachment 8539514 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r+ assuming you've checked we don't end up losing a specificity fight
> somewhere and then use the default theme's hover color: .

That comment made me discover something interesting - the tab-color variable never actually applies due to this rule: http://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/tabs.inc.css#164.  So the tab-color variable is pointless right now.  We could either remove that as well, or use an !important on the usage here: http://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/devedition.inc.css#286.
Sorry for all the requests in a row.  As I mention in Comment 4, the tab-color variable was never even being applied due to a more specific rule in the tabs.inc.css file.  We may as well remove the code since it won't affect the UI and it should make things clearer.
Attachment #8539514 - Attachment is obsolete: true
Attachment #8539534 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8539534 [details] [diff] [review]
undefined-var.patch

Review of attachment 8539534 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with a followup to design something sensible for the dark case as per IRC
Attachment #8539534 - Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/integration/fx-team/rev/af571b8e561d
Whiteboard: [devedition-polish] → [fixed-in-fx-team][devedition-polish]
Blocks: 1113867
https://hg.mozilla.org/mozilla-central/rev/af571b8e561d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team][devedition-polish] → [devedition-polish]
Target Milestone: --- → Firefox 37
You need to log in before you can comment on or make changes to this bug.