1112715 - --tab-hover-color variable in devedition theme causes "Property contained reference to invalid variable. Error in parsing value for 'color'. Falling back to 'inherit'."

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Brian Grinstead [:bgrins]]

This variable is used but never defined: http://dxr.mozilla.org/mozilla-central/search?q=tab-hover-color&redirect=true.

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: undefined-var.patch

This was a typo / oversight on my part

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: undefined-var.patch

Instead just removing the variable reference as discussed on IRC.  The color change isn't that obvious anyway so going to remove CSS instead of adding it.

Comment 3

[:Gijs (he/him)]

Comment on attachment 8539514 [details] [diff] [review]
undefined-var.patch

Review of attachment 8539514 [details] [diff] [review]:
-----------------------------------------------------------------

r+ assuming you've checked we don't end up losing a specificity fight somewhere and then use the default theme's hover color: .

Comment 4

[Brian Grinstead [:bgrins]]

(In reply to :Gijs Kruitbosch from comment #3)
> Comment on attachment 8539514 [details] [diff] [review]
> undefined-var.patch
> 
> Review of attachment 8539514 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r+ assuming you've checked we don't end up losing a specificity fight
> somewhere and then use the default theme's hover color: .

That comment made me discover something interesting - the tab-color variable never actually applies due to this rule: http://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/tabs.inc.css#164.  So the tab-color variable is pointless right now.  We could either remove that as well, or use an !important on the usage here: http://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/devedition.inc.css#286.

Comment 5

[Brian Grinstead [:bgrins]]

Attachment: undefined-var.patch

Sorry for all the requests in a row.  As I mention in Comment 4, the tab-color variable was never even being applied due to a more specific rule in the tabs.inc.css file.  We may as well remove the code since it won't affect the UI and it should make things clearer.

Comment 6

[:Gijs (he/him)]

Comment on attachment 8539534 [details] [diff] [review]
undefined-var.patch

Review of attachment 8539534 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with a followup to design something sensible for the dark case as per IRC

Comment 7

[Brian Grinstead [:bgrins]]

https://hg.mozilla.org/integration/fx-team/rev/af571b8e561d

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/af571b8e561d