1112737 - Delete all sipcc _build_attr_ functions and associated machinery

Status: NEW

(Core :: WebRTC: Signaling, defect, P5)

Description

[Martin Thomson [:mt:]]

We have our own SDP serializers now.  It's time to delete some more code.

Comment 1

[chaithanya]

Hi
  I would like to work on this bug. Can you please tell me how to proceed?

Comment 2

[Byron Campen [:bwc]]

Basically, all of the stuff here needs to be removed (excepting perhaps sdp_build_attr_fmtp_params, since we actually use it, although I suspect we could remove that too):

https://dxr.mozilla.org/mozilla-central/search?q=sdp_build_attr&redirect=false&case=false

Removing all of those will necessitate removing stuff like this, which is presently used in some places in sdp_unittests.cpp:

https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/src/sdp/sipcc/sdp_main.c#1182

These test-cases will need to be modified to use the new serialization code. An example of this is here:

https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/test/sdp_unittests.cpp?from=sdp_unittests.cpp#878

Comment 3

[Bulk Bug Changes for mreavy's org]

Mass change P4->P5 to align with new Mozilla triage process.

Comment 4

[manikishanghantasala]

I am a newbie and I would like to work on it.Can I proceed??

Comment 5

[manikishanghantasala]

In this bug can we delete sdp_build_attr_.... functions too?