Delete all sipcc _build_attr_ functions and associated machinery

NEW
Unassigned

Status

()

Core
WebRTC: Signaling
P5
normal
Rank:
45
3 years ago
2 months ago

People

(Reporter: mt, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: good first bug)

(Reporter)

Description

3 years ago
We have our own SDP serializers now.  It's time to delete some more code.

Updated

3 years ago
backlog: --- → tech-debt
Rank: 45
Priority: -- → P4
(Reporter)

Updated

3 years ago
Whiteboard: good first bug

Comment 1

2 years ago
Hi
  I would like to work on this bug. Can you please tell me how to proceed?

Comment 2

2 years ago
Basically, all of the stuff here needs to be removed (excepting perhaps sdp_build_attr_fmtp_params, since we actually use it, although I suspect we could remove that too):

https://dxr.mozilla.org/mozilla-central/search?q=sdp_build_attr&redirect=false&case=false

Removing all of those will necessitate removing stuff like this, which is presently used in some places in sdp_unittests.cpp:

https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/src/sdp/sipcc/sdp_main.c#1182

These test-cases will need to be modified to use the new serialization code. An example of this is here:

https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/test/sdp_unittests.cpp?from=sdp_unittests.cpp#878
Mass change P4->P5 to align with new Mozilla triage process.
Priority: P4 → P5

Comment 4

2 months ago
I am a newbie and I would like to work on it.Can I proceed??

Comment 5

2 months ago
In this bug can we delete sdp_build_attr_.... functions too?
You need to log in before you can comment on or make changes to this bug.