Closed
Bug 1112747
Opened 6 years ago
Closed 6 years ago
Change plugins::IPCByteRanges from std::vector to nsTArray
Categories
(Core :: Plug-ins, defect)
Core
Plug-ins
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: jld, Assigned: jld)
Details
Attachments
(1 file)
|
2.50 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
mozilla::plugins::IPCByteRanges is a std::vector, but we generally prefer nsTArray (among other reasons, it doesn't use the standard library allocator concept, which depends on exceptions), and there's no obvious reason it can't be changed.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8538051 -
Flags: review?(jmathies)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8538051 [details] [diff] [review] bug1112747-byteranges-to-ns-hg0.diff lgtm!
Attachment #8538051 -
Flags: review?(jmathies) → review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
Try looks green enough: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=dbad7e9764ad
Keywords: checkin-needed
|
||
Comment 4•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad79358ea0e0
Keywords: checkin-needed
|
||
Comment 5•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ad79358ea0e0
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•