1112765 - Allow proxy handlers to implement custom trace behaviour

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Josh Matthews [:jdm]]

This is necessary for Servo's DOM bindings.

Comment 1

[Josh Matthews [:jdm]]

Attachment: Add an overridable trace hook to BaseProxyHandler

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 8538075 [details] [diff] [review]
Add an overridable trace hook to BaseProxyHandler

Review of attachment 8538075 [details] [diff] [review]:
-----------------------------------------------------------------

We discussed this in Portland and I think we're okay with taking it -- forwarding review to someone who can actually comment on the mechanical details though.

Comment 3

[Eric Faust [:efaust]]

Comment on attachment 8538075 [details] [diff] [review]
Add an overridable trace hook to BaseProxyHandler

Review of attachment 8538075 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, this should be fine. We trust people to write tracers already, so this is no worse.

Comment 4

[Josh Matthews [:jdm]]

A try push won't be useful here.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/df5938ac7dfa

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/df5938ac7dfa