111291 - MLK: leaking many char* in nsMsgAttachmentHandler

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[Navin Gupta]

From purify

[W] MLK: Memory leak of 5 bytes from 1 block allocated in PL_strdup
        Distribution of leaked blocks
        Allocation location
            malloc         [dbgheap.c:129]
            PL_strdup      [strdup.c:46]
            nsMsgAttachmentHandler::PickEncoding(char const*,nsIMsgSend *) 
[nsMsgAttachmentHandler.cpp:319]
                      }
                      else {
                        PR_FREEIF(m_encoding);
             =>         m_encoding = PL_strdup (ENCODING_7BIT);
                      }
                  }
                
            nsMsgComposeAndSend::GatherMimeAttachments(void) [nsMsgSend.cpp:781]
            nsMsgAttachmentHandler::UrlExit(UINT,WORD const*) 
[nsMsgAttachmentHandler.cpp:1175]
            FetcherURLDoneCallback [nsMsgAttachmentHandler.cpp:469]
            nsURLFetcher::OnStopRequest(nsIRequest *,nsISupports *,UINT) 
[nsURLFetcher.cpp:322]
            nsDocumentOpenInfo::OnStopRequest(nsIRequest *,nsISupports *,UINT) 
[nsURILoader.cpp:252]
            nsFileChannel::OnStopRequest(nsIRequest *,nsISupports *,UINT) 
[nsFileChannel.cpp:481]
            nsOnStopRequestEvent::HandleEvent(void) 
[nsRequestObserverProxy.cpp:176]
[W] MLK: Memory leak of 11 bytes from 1 block allocated in PL_strdup
        Distribution of leaked blocks
        Allocation location
            malloc         [dbgheap.c:129]
            PL_strdup      [strdup.c:46]
            nsMsgComposeAndSend::GatherMimeAttachments(void) [nsMsgSend.cpp:647]
                    PR_FREEIF(m_plaintext->m_charset);
                    m_plaintext->m_charset = 
PL_strdup(mCompFields->GetCharacterSet());
                    PR_FREEIF(m_plaintext->m_desired_type);
             =>     m_plaintext->m_desired_type = PL_strdup(TEXT_PLAIN);
                    m_attachment_pending_count ++;
                    status = m_plaintext->SnarfAttachment(mCompFields);
                    if (status < 0)
            nsMsgComposeAndSend::HackAttachments(nsMsgAttachmentData 
const*,nsMsgAttachedFile const*) [nsMsgSend.cpp:2586]
            nsMsgComposeAndSend::Init(nsIMsgIdentity *,nsMsgCompFields 
*,nsFileSpec *,int,int,int,nsIMsgDBHdr *,char const*,char 
const*,UINT,nsMsgAttachmentData const*,nsMsgAttachedFile const*,char const*) 
[nsMsgSend.cpp:2949]
            nsMsgComposeAndSend::CreateAndSendMessage(nsIEditorShell 
*,nsIMsgIdentity *,nsIMsgCompFields *,int,int,int,nsIMsgDBHdr *,char const*,char 
const*,UINT,nsMsgAttachmentData const*,nsMsgAttachedFile const*,void 
*,nsIDOMWindowInternal *,nsIMsgProgress *,nsIMs [nsMsgSend.cpp:3699]
            nsMsgCompose::_SendMsg(int,nsIMsgIdentity *,int) 
[nsMsgCompose.cpp:874]
            nsMsgCompose::SendMsg(int,nsIMsgIdentity *,nsIMsgProgress *) 
[nsMsgCompose.cpp:980]
            XPTC_InvokeByIndex [xptcinvoke.cpp:152]
            
XPCWrappedNative::CallMethod(XPCCallContext&,CallMode::XPCWrappedNative) 
[xpcwrappednative.cpp:2009]
[W] MLK: Memory leak of 11 bytes from 1 block allocated in PL_strdup
        Distribution of leaked blocks
        Allocation location
            malloc         [dbgheap.c:129]
            PL_strdup      [strdup.c:46]
            nsMsgComposeAndSend::GatherMimeAttachments(void) [nsMsgSend.cpp:645]
                    PR_FREEIF(m_plaintext->m_type);
                    m_plaintext->m_type = PL_strdup(TEXT_HTML);
                    PR_FREEIF(m_plaintext->m_charset);
             =>     m_plaintext->m_charset = 
PL_strdup(mCompFields->GetCharacterSet());
                    PR_FREEIF(m_plaintext->m_desired_type);
                    m_plaintext->m_desired_type = PL_strdup(TEXT_PLAIN);
                    m_attachment_pending_count ++;
            nsMsgComposeAndSend::HackAttachments(nsMsgAttachmentData 
const*,nsMsgAttachedFile const*) [nsMsgSend.cpp:2586]
                
                  // If no attachments - finish now (this will call the 
done_callback).
                  if (needToCallGatherMimeAttachments)
             =>     return GatherMimeAttachments();
                
                  return 0;
                }
            nsMsgComposeAndSend::Init(nsIMsgIdentity *,nsMsgCompFields 
*,nsFileSpec *,int,int,int,nsIMsgDBHdr *,char const*,char 
const*,UINT,nsMsgAttachmentData const*,nsMsgAttachedFile const*,char const*) 
[nsMsgSend.cpp:2949]
            nsMsgComposeAndSend::CreateAndSendMessage(nsIEditorShell 
*,nsIMsgIdentity *,nsIMsgCompFields *,int,int,int,nsIMsgDBHdr *,char const*,char 
const*,UINT,nsMsgAttachmentData const*,nsMsgAttachedFile const*,void 
*,nsIDOMWindowInternal *,nsIMsgProgress *,nsIMs [nsMsgSend.cpp:3699]
            nsMsgCompose::_SendMsg(int,nsIMsgIdentity *,int) 
[nsMsgCompose.cpp:874]
            nsMsgCompose::SendMsg(int,nsIMsgIdentity *,nsIMsgProgress *) 
[nsMsgCompose.cpp:980]
            XPTC_InvokeByIndex [xptcinvoke.cpp:152]
            
XPCWrappedNative::CallMethod(XPCCallContext&,CallMode::XPCWrappedNative) 
[xpcwrappednative.cpp:2009]

Comment 1

[Navin Gupta]

Attachment: proposed fix

all the char* should be destroyed in the destructor.

Comment 2

[Navin Gupta]

cc ducarroz for review

I have tested it w/ attachment and plain/text html message. I don't 
see the attachment handler itself leaking so this will fix it. 

Comment 3

[Jean-Francois Ducarroz]

Comment on attachment 58769 [details] [diff] [review]
proposed fix

R=ducarroz

Comment 4

[Navin Gupta]

Attachment: proposed fix

I have found two more char*

Comment 5

[Navin Gupta]

cc bienvenu for sr.

Comment 6

[David :Bienvenu]

Comment on attachment 58775 [details] [diff] [review]
proposed fix

looks good - it also looks like it's the same leak as the one we were recently
discussing.

Comment 7

[[e-mail] (gone - use [e-mail] instead)]

Bug 99112 is a dup of this, right?

Comment 8

[David :Bienvenu]

Stephen, yes, I think so. I think bug 111083 might also be a dup of this bug.

Comment 9

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 99112 has been marked as a duplicate of this bug. ***

Comment 10

[Navin Gupta]

*** Bug 111083 has been marked as a duplicate of this bug. ***

Comment 11

[Navin Gupta]

fix checked in.

Comment 12

[Navin Gupta]

*** Bug 99177 has been marked as a duplicate of this bug. ***

Comment 13

[[e-mail] (gone - use [e-mail] instead)]

verified fixed.