Closed Bug 1112925 Opened 7 years ago Closed 7 years ago

Stop calling into XPCWrappedJS with an exception on the stack in CheckForPendingException

Categories

(Core :: XPConnect, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(1 file)

We need to do this before we can fix the assert in bug 1112920.
Comment on attachment 8538178 [details] [diff] [review]
Don't re-enter JS with a pending exception in CheckForPendingException. v1

Actually, I think terrence should review this.
Attachment #8538178 - Flags: review?(bobowencode) → review?(terrence)
Comment on attachment 8538178 [details] [diff] [review]
Don't re-enter JS with a pending exception in CheckForPendingException. v1

Review of attachment 8538178 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, it is all the dumb.
Attachment #8538178 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/9fa4c542936b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.