111294 - unable to build NSS for QNX6 (Neutrino)

Status: RESOLVED FIXED

(NSS :: Build, defect, P1)

Description

[Dave Inglis]

QNX6 (Neutrino) is not supported in NSS
(patch to follow)

Comment 1

[Dave Inglis]

Attachment: patch to support QNX6 in NSS

patch based on NSS_CLIENT_TAG

Comment 2

[timeless]

*** Bug 110967 has been marked as a duplicate of this bug. ***

Comment 3

[Wan-Teh Chang]

Comment on attachment 58758 [details] [diff] [review]
patch to support QNX6 in NSS

>Index: nss/lib/ssl/unix_err.c
>===================================================================
>RCS file: /cvsroot/mozilla/security/nss/lib/ssl/unix_err.c,v
>retrieving revision 1.3
>diff -u -r1.3 unix_err.c
>--- unix_err.c	2001/03/13 19:02:05	1.3
>+++ unix_err.c	2001/11/21 21:34:37
>@@ -48,7 +48,7 @@
> #include "prerror.h"
> #endif
> 
>-#if defined (__bsdi__)
>+#if defined (__bsdi__) || defined(NTO)
> #undef _PR_POLL_AVAILABLE
> #endif
>
>@@ -468,8 +468,10 @@
> #ifdef EBADMSG
>     case EBADMSG:	prError = PR_IO_ERROR; break;
> #endif
>-    case EBUSY:		prError = PR_FILESYSTEM_MOUNTED_ERROR; break;
>-    case ECONNREFUSED:	prError = PR_CONNECT_REFUSED_ERROR; break;
>+#ifndef NTO
>+	case EBUSY:		prError = PR_FILESYSTEM_MOUNTED_ERROR; break;
>+#endif
>+	case ECONNREFUSED:	prError = PR_CONNECT_REFUSED_ERROR; break;
>     case ECONNRESET:	prError = PR_CONNECT_RESET_ERROR; break;
>     case EDEADLK:	prError = PR_DEADLOCK_ERROR; break;
> #ifdef EDIRCORRUPTED

Could you explain your second change to this file?
Why do you need to comment out the EBUSY case for
NTO?  EBUSY is also used in the nss_MD_unix_map_open_error()
function in the same file.  Why isn't that a problem?

Comment 4

[Wan-Teh Chang]

One thing I can do is to add a QNX.mk file to mozilla/security/coreconf
that is to be used by all QNX versions.  This will avoid having to add a
QNXx.y.z.mk file whenever a new QNX version (x.y.z) is released.  This
common QNX.mk file will need to handle all QNX versions though, which is
not necessarily difficult to do.

Would you like me to do that?

By the way, what does 'uname -s' return on QNX6?

Comment 5

[Dave Inglis]

Sure, that sounds fine.

'uname -s' -> 'QNX'

Also EBUSY is removed because EBUSY == EALREADY on QNX which in unix_err.c
causes an error with duplicates in the switch.

Comment 6

[Wan-Teh Chang]

Attachment: patch to support QNX6 in NSS.

This is Dave Inglis's patch with the following changes.
1. I use a single QNX.mk for all QNX versions.
2. I use the same fix for the EBUSY == EALREADY problem
   that I used in NSPR.

Please let me know if this patch works for you.

Comment 7

[Brian Edmond]

I tried it and it work fine for me.  If you can put it in that would be great.

Comment 8

[Wan-Teh Chang]

Thanks for verifying that my patch works for you.

I checked my patch into the tip of NSS.  I need to wait for
the right time to put it in NSS_CLIENT_TAG.  We are having
a code freeze on that branch right now.  When do you need
this fix in NSS_CLIENT_TAG?

Comment 9

[Brian Edmond]

I guess I would like to see it as soon as possible.  What I am looking for is to
be able to grad a mozilla release tag tree and build it with crypto support
without touching it.  I guess the next release would be good.

Comment 10

[Wan-Teh Chang]

Sorry, I totally forgot about this bug.  Your patch is
still not in NSS_CLIENT_TAG yet.

We are planning to land NSS 3.4 in the next two weeks.
If you don't mind, I would like to land your patch along
with the rest of NSS 3.4. 

Comment 11

[Wan-Teh Chang]

NSS 3.4 landed today.  This fix is in NSS_CLIENT_TAG now.
Marked the bug fixed.