1112943 - [jsdbg2] Cache Debugger.Source.prototype.text

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Shu-yu Guo [:shu]]

This ends up allocating a lot, like a lot a lot.

Comment 1

[Shu-yu Guo [:shu]]

Attachment: Cache Debugger.Source.text.

Comment 2

[Jim Blandy :jimb]

Comment on attachment 8538182 [details] [diff] [review]
Cache Debugger.Source.text.

Review of attachment 8538182 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/Debugger.cpp
@@ +89,5 @@
>  extern const Class DebuggerSource_class;
>  
>  enum {
>      JSSLOT_DEBUGSOURCE_OWNER,
> +    JSSLOT_DEBUGSOURCE_TEXT,

Do we not need to initialize this slot in Debugger::newDebuggerSource? Are reserved slots initialized to 'undefined' already?

Comment 3

[Shu-yu Guo [:shu]]

(In reply to Jim Blandy :jimb from comment #2)
> Comment on attachment 8538182 [details] [diff] [review]
> Cache Debugger.Source.text.
> 
> Review of attachment 8538182 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: js/src/vm/Debugger.cpp
> @@ +89,5 @@
> >  extern const Class DebuggerSource_class;
> >  
> >  enum {
> >      JSSLOT_DEBUGSOURCE_OWNER,
> > +    JSSLOT_DEBUGSOURCE_TEXT,
> 
> Do we not need to initialize this slot in Debugger::newDebuggerSource? Are
> reserved slots initialized to 'undefined' already?

I'll make sure, but I'm pretty sure that reserved slots are initialized automatically.

Comment 4

[Ekanan Ketunuti]

https://hg.mozilla.org/mozilla-central/rev/5b12b200cbd7