Closed Bug 1112978 Opened 9 years ago Closed 9 years ago

[STK] Use mozbehavior.showOnlyOnce = true to create IDLE MODE TEXT notifications

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: selee, Assigned: selee)

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
frsela
: review+
gerard-majax
: feedback+
Details | Review
We should use the attribute mozbehavior.showOnlyOnce = true for creating a new notification instead of removing the notification at gaia's initialization .

Please see Alexandre's comment at bug 1106956 comment 27.
Assignee: nobody → selee
Attached file PR for master
Hi Alexandre,

Here is my PR for this bug.
Please help to review it.
Thank you.
Attachment #8538248 - Flags: review?(lissyx+mozillians)
Comment on attachment 8538248 [details] [review]
PR for master

I'm not a system peer, please ask review to the proper person.
Attachment #8538248 - Flags: review?(lissyx+mozillians) → feedback?(lissyx+mozillians)
Comment on attachment 8538248 [details] [review]
PR for master

See comment on Github
Attachment #8538248 - Flags: feedback?(lissyx+mozillians) → feedback+
Comment on attachment 8538248 [details] [review]
PR for master

Hello Fernando,

Here is my PR for this bug. Please help to review it. Thank you.
Attachment #8538248 - Flags: review?(frsela)
Comment on attachment 8538248 [details] [review]
PR for master

LGTM
Attachment #8538248 - Flags: review?(frsela) → review+
Hi Fernando,

v2.0m still uses clearIdleTextNotification to clear the notification even though the show only once is a better solution.
How do you think if we remain the code of "clearIdleTextNotification" ?
Flags: needinfo?(frsela)
(In reply to Sean Lee [:seanlee] from comment #6)
> Hi Fernando,
> 
> v2.0m still uses clearIdleTextNotification to clear the notification even
> though the show only once is a better solution.
> How do you think if we remain the code of "clearIdleTextNotification" ?

Fully agree !
Flags: needinfo?(frsela)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.