1112980 - Many duplicate keydir reports when committing conf/gitolite.conf

Status: RESOLVED WONTFIX

(Developer Services :: Git, defect)

Description

[hwine]

Committing the configuration file very nicely does an automatic deploy. However, there are many duplicate key warnings reported, which could mask deployment errors.

As I understand the messages and concept, the duplicate keys provide no end user value.

Comment 1

[Kendall Libby [:fubar] (he/him)]

I don't think there's any way to fix this bar modifiying gitolite itself.

/usr/share/gitolite3/triggers/post-compile/ssh-authkeys:

for my $f (@pubkeys) {
    my $fp = fp($f) || "";
    if ($fp eq "") { next } ;
    if ( $seen{$fp} ) {
        _warn "$f duplicates $seen{$fp}, sshd will ignore it";
    } else {
        $seen{$fp} = $f;
    }
    push @gl_keys, grep { /./ } optionise($f);
}

One can, in theory, change what _warn() does, but then we run the risk of missing other important things. Also, sometimes it *is* useful to see these messages, as we've had cases where people have the same key on multiple accounts that have different privs and wonder why their access doesn't work.