1113004 - Add IsPrivateResponse to HttpChannel

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[François Marier [:francois]]

nsIHttpChannel already has an isNoStoreResponse method to check for "Cache-control: no-store":

  http://dxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/nsIHttpChannel.idl#289

Honza suggested (https://bugzilla.mozilla.org/show_bug.cgi?id=992096#c24) a new isPrivateResponse method to make it easier to check for publicly cachable resources in the sub-resource integrity code (bug 992096).

Comment 1

[François Marier [:francois]]

Attachment: Implementation with a very basic test

Honza, Is that what you had in mind for the nsIHttpChannel.IsPrivateResponse()?

I added a very basic test, but if there's a good place to test this properly, please let me know and I'll add it. I've tested it manually as part of my patch for bug 992096.

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 8538286 [details] [diff] [review]
Implementation with a very basic test

Review of attachment 8538286 [details] [diff] [review]:
-----------------------------------------------------------------

You also need to update netwerk\protocol\http\PHttpChannelParams.h to carry this new member via IPC.

::: netwerk/protocol/http/nsIHttpChannel.idl
@@ +305,5 @@
> +     *
> +     * @throws NS_ERROR_NOT_AVAILABLE if called before the response
> +     *         has been received (before onStartRequest).
> +     */
> +    boolean isPrivateResponse();

modify IID !

Comment 3

[François Marier [:francois]]

Attachment: Implementation with a very basic test

This new patch fixes the issues highlighted in comment 2 (thanks Honza!).

Try run here: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=463b98759baa

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/33ea628dd337

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/33ea628dd337