1113006 - Screen manager ScreenForBrowser message should return primary screen as fallback

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: screen-mgr

Filing this regarding bug 1091705 comment 27. The basic problem is that we want window.screen.width to return a non-zero value even after the window has been closed. Right now the e10s code fails in ScreenManagerParent::RecvScreenForBrowser when getting a null result for GetWidget().

Based on http://mxr.mozilla.org/mozilla-central/source/gfx/src/nsDeviceContext.cpp#644, it seems like we should return the dimensions of the primary screen in this case. So that's what this patch does.

I don't have a multiple monitor setup to test this, but it seems pretty safe.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/06d89851a3a5

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/06d89851a3a5