1113016 - Add a panel to manage Addons

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: PR

Arthur, let me know if you need details about that! The goal is to list the new "addon" apps in a panel and be able to enable or disable them using the mozApps api.

We'll need a new icon for that. I have no idea how to do that. It seems that the current code picks up some semi random icon that I kind of like ;)

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8538288 [details] [review]
PR

Thanks for adding the panel, Fabrice.

I left some comments in github regarding separating the logic of UI and data. And then we also need unit tests for the Addons module. Let me know if any problems, thanks!

Comment 3

[[:fabrice] Fabrice Desré]

Arthur, thanks for the review, it looks like copy/pasting from the theme panel was not that a great idea!

I won't have time to look at that for a few weeks, so if you have someone on your side to make that move on that would be much appreciated!

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Fabrice, we will try to move this forward if all of our planned 2.2 features are finished. (I guess this one is not for 2.2, am I correct?) 

Include EJ as I will be on PTO in the next two weeks.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Can try to have a look, but cannot promise to be done by the end of this week sorry :S

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 27383

Hi,

Fabrice I've been trying to get your patch and come with the separation than Arthur asked.

Arthur, hope this separation is what you were mentioning.

Things that are still needed, unit test, open a bug to create the icon and add it to the gaia font, and a way of uninstalling, so far we are just enabling and disabling, guess we can do that in a follow up.

Comment 7

[[:fabrice] Fabrice Desré]

Comment on attachment 8548871 [details] [review]
Pointer to PR 27383

Thanks Fernando. lgtm, but I let Arthur review.

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8548871 [details] [review]
Pointer to PR 27383

Looks good! However, there are some issues to be addressed. Details please refer to github, thanks.

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8548871 [details] [review]
Pointer to PR 27383

Hi Arthur,

tried to address the comments on gh, and added simple unit test.

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8548871 [details] [review]
Pointer to PR 27383

r=me with the last comments addressed, thanks!

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/8a916e0b9cf89e2b1de780f1e9f7dbca360efe20

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

Fabrice do you want this in 2.2?

Comment 13

[Francesco Lodolo [:flod]]

String needs a fix (no need to update the string ID): the correct spelling is add-on, not addon.

Comment 14

[[:fabrice] Fabrice Desré]

(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #12)
> Fabrice do you want this in 2.2?

Not sure yet... I may have to disable add-on support altogether because of some platform issue that is yet unresolved.

Comment 15

[Adrian Aichner [:anaran]]

(In reply to Francesco Lodolo [:flod] from comment #13)
> String needs a fix (no need to update the string ID): the correct spelling
> is add-on, not addon.

yep. see also Bug 1122981

Comment 16

[David Flanagan [:djf]]

I've filed 1131773 as a followup to turn this simple enable/disable panel into a more full-featured "Add-on Manager" that displays more information about each add-on and also allows an addon to be deleted.

Comment 17

[Adrian Aichner [:anaran]]

Bug 1131773