Closed Bug 1113018 Opened 10 years ago Closed 10 years ago

x86-64 masm.extractObject does what looks like an unnecessary mov

Categories

(Core :: JavaScript Engine: JIT, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file)

Here's the codegen I see for the masm.extractObject call in CallDOMNative: movq 0x0(%rsp), %r11 movabsq $0x7fffffffffff, %rsi andq %r11, %rsi With the patch I'm about to attach this becomes: movabsq $0x7fffffffffff, %rsi andq 0x0(%rsp), %rsi
Comment on attachment 8538290 [details] [diff] [review] Stop manually moving things into ScratchReg in the x86-64 version of extractObject; just rely on unboxNonDouble doing the right thing as needed Review of attachment 8538290 [details] [diff] [review]: ----------------------------------------------------------------- Nice, that eliminates an ugly coupling at the same time!
Attachment #8538290 - Flags: review?(sunfish) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: