1113028 - [Flame][Settings]There is nothing in Region and City list when there is no SIM in phone

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Sue]

Attachment: video

[1.Description]:
[Flame v2.2][Settings]There is nothing in droplist of Region and City when you go to change date & time.
Found time:20:45
See attachment: 2045.MP4 and logcat_2045.txt

[2.Testing Steps]: 
1. Launch Settings.
2. Select Date & Time.
3. Tap droplist of Region and City under Time zone.

[3.Expected Result]: 
3. There should be countries and cities in Time zone.

[4.Actual Result]: 
3. There is nothing in Time zone.

[5.Reproduction build]: 
Flame 2.2 build:
Gaia-Rev        d22dfece04fc00457e8369c660c11f945b088d2f
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/cb8ad2251c09
Build-ID        20141217160203
Version         37.0a1

[6.Reproduction Frequency]: 
Always Recurrence,5/5
TCID: Free Test

Comment 1

[Sue]

Attachment: logcat_2045.txt

Comment 2

[Sue]

Hi Eric,
This issue can be repro on lasted Flame 2.2, could you help with it? Thanks!
Flame 2.2 build:
Gaia-Rev        3554ea9504046646b4679e3a61317c49fc55ca87
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/67c42c076393
Build-ID        20141228010205
Version         37.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141228.045435
FW-Date         Sun Dec 28 04:54:46 EST 2014
Bootloader      L1TC00011880

Comment 3

[Eric Chang [:ericcc] [:echang]]

Hi Kevin, Could you help with this, items missing from the lists after removing the SIM from phone

Comment 4

[Kevin Grandon :kgrandon]

It seems like a regression. Is it possible to get a regression window here?

Comment 5

[Kevin Grandon :kgrandon]

Nevermind, seems it's gaia-only and pretty easy to bisect. I'll do a quick bisection.

Comment 6

[Kevin Grandon :kgrandon]

I had a build on my phone which worked, so here's the gaia bisection:

git bisect start
git bisect good 7a2bb8c48eb87b5d704cbab8905e859630f645d9
git bisect bad 4114b0b717a238086d06f8322d96f66b0263184d
Bisecting: a merge base must be tested
[689bdc8d7e0e89127c23f524cf5e558b9e5deb33] Merge pull request #26729 from mpizza/Bug_1099019_master

git bisect good
Bisecting: 206 revisions left to test after this (roughly 8 steps)
[9a99b5deba9ba20bde3a0ff5402908ba84d87c92] Merge pull request #26881 from albertopq/1112520-icons-rocketbar

git bisect bad
Bisecting: 103 revisions left to test after this (roughly 7 steps)
[04c256b7f00b44939d9f4932509ef97702241886] Merge pull request #26738 from luke-chang/1105977_sms_unsent_discard_useless

git bisect bad
Bisecting: 52 revisions left to test after this (roughly 6 steps)
[c5b01c018e79a36d7ca1e466c143c76fac7da705] Merge pull request #26782 from viorelaioia/revert_ftu_with_tour_commit

git bisect bad
Bisecting: 24 revisions left to test after this (roughly 5 steps)
[a59198af43708807bd826075680c20257cc32fba] Merge pull request #26581 from punamdahiya/Bug1088413

git bisect bad
Bisecting: 12 revisions left to test after this (roughly 4 steps)
[cff39ae4f328806a325cbc09924ad10ba362c253] Bug 1107355 - [Status Bar][Bluetooth] Status bar turns black when the device is connected with another device via Bluetooth

git bisect bad
Bisecting: 6 revisions left to test after this (roughly 3 steps)
[0de95b4017de73e72c897e2dcb87564d8f3756eb] Merge pull request #26683 from crh0716/1109387

git bisect good
Bisecting: 2 revisions left to test after this (roughly 2 steps)
[739dd45496e9d0f1806dc67faf0244c18c5dd3ac] Merge pull request #22522 from comoyo/bug971688

git bisect good
Bisecting: 0 revisions left to test after this (roughly 1 step)
[19f12e8d9308f8d7fde3b97c7f8b7b58bd876222] Merge pull request #26688 from crh0716/1090843_1

git bisect bad
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[d2bccd0db13df3e72187456eff820b108ef29d8a] Bug 1090843 - Remove non-required modules from the loading path of the root panel

git bisect bad
d2bccd0db13df3e72187456eff820b108ef29d8a is the first bad commit
commit d2bccd0db13df3e72187456eff820b108ef29d8a
Author: Arthur Chen <[e-mail]>
Date:   Wed Oct 29 18:25:48 2014 +0800

    Bug 1090843 - Remove non-required modules from the loading path of the root panel

Seems like this is caused by bug 1090843.

Comment 7

[Kevin Grandon :kgrandon]

Seems this is logged: W/Settings(14361): [JavaScript Error: "ReferenceError: IccHelper is not defined" {file: "app://settings.gaiamobile.org/shared/js/tz_select.js" line: 62}]

Comment 8

[Kevin Grandon :kgrandon]

Seems like it's just a dependency problem, though we should also add a test.

Comment 9

[GitHub Autolander Bot]

Attachment: [PullReq] KevinGrandon:bug_1113028_settings_tz_select_deps to mozilla-b2g:master

Comment 10

[Kevin Grandon :kgrandon]

Comment on attachment 8542163 [details] [review]
[PullReq] KevinGrandon:bug_1113028_settings_tz_select_deps to mozilla-b2g:master

Arthur, or maybe EJ since Arthur is on PTO - could one of you guys review this? I've added some simple test scaffolding for this panel which follows what we do elsewhere in the settings app. Thanks!

Comment 11

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8542163 [details] [review]
[PullReq] KevinGrandon:bug_1113028_settings_tz_select_deps to mozilla-b2g:master

Thanks Kevin !! r+

Comment 12

[Kevin Grandon :kgrandon]

Thanks for the review. In master: https://github.com/mozilla-b2g/gaia/commit/040d1487e5c702a153f32784935afadf5c476a5c

Comment 13

[Sue]

Attachment: verify_video.MP4

The problem is verified not happen in latest build of Flame 2.2 
See attachment:verify_video.MP4

Flame 2.2 build:
Gaia-Rev        698e6e8a098cc060b26cd6f25171633c4c7e739d
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/57e4e9c33bef
Build-ID        20150103010205
Version         37.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150103.045144
FW-Date         Sat Jan  3 04:51:56 EST 2015
Bootloader      L1TC000118D0