Adapt Debugger Server startup code for changes in bug 1059001. error DebuggerServer.openListener is not a function

VERIFIED FIXED in Thunderbird 37.0

Status

defect
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: Fallen, Assigned: MakeMyDay)

Tracking

30 Branch
Thunderbird 37.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

In bug 1059001, openListener has changed. See for example https://reviewboard.mozilla.org/r/1113/diff/2/#4

The Thunderbird actor needs to be adapted.
OS: Mac OS X → All
Posted patch FixRemoteDebuggerServer-v1.diff (obsolete) β€” β€” Splinter Review
The fix ports the the approach from bug 1059001 to Thunderbird.
Assignee: nobody → makemyday
Status: NEW → ASSIGNED
Attachment #8539837 - Flags: review?(mkmelin+mozilla)
There's another occurrence of DebuggerServer.openListener in CC - see http://mxr.mozilla.org/comm-central/source//suite/common/src/nsSuiteGlue.js#981

I don't know if this is an issue for Seamonkey - if so, they probably haven't noticed this, because they're swallowing any error for this.
The Seamonkey folks probably wouldn't mind if you fixed it for them :-P Up to you though if you have time.
I don't mind to do so - who would be the one to request the review from?
I'd go with the same reviewer(s) as in bug 973530
Updated patch for Thunderbird with removed whitespaces.
Attachment #8539837 - Attachment is obsolete: true
Attachment #8539837 - Flags: review?(mkmelin+mozilla)
Attachment #8540066 - Flags: review?(mkmelin+mozilla)
Patch for Seamonkey.
Attachment #8540070 - Flags: review?(neil)
Comment on attachment 8540070 [details] [diff] [review]
FixRemoteDebuggerServer-SM-v1.diff

Thanks for the patch!
Attachment #8540070 - Flags: review?(neil) → review+
Comment on attachment 8540066 [details] [diff] [review]
FixRemoteDebuggerServer-TB-v2.diff

Review of attachment 8540066 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx! r=mkmelin
Attachment #8540066 - Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/c44eb2f54c29
https://hg.mozilla.org/comm-central/rev/b23c7800c7a6
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 37.0
Confirm this now works.  I had tried 2014-12-26 build which failed.
Status: RESOLVED → VERIFIED
Summary: Adapt Debugger Server startup code for changes in bug 1059001 → Adapt Debugger Server startup code for changes in bug 1059001. error DebuggerServer.openListener is not a function
You need to log in before you can comment on or make changes to this bug.