1113035 - Adapt Debugger Server startup code for changes in bug 1059001. error DebuggerServer.openListener is not a function

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[Philipp Kewisch [:Fallen][📱📆]]

In bug 1059001, openListener has changed. See for example https://reviewboard.mozilla.org/r/1113/diff/2/#4

The Thunderbird actor needs to be adapted.

Comment 1

[[:MakeMyDay]]

Attachment: FixRemoteDebuggerServer-v1.diff

The fix ports the the approach from bug 1059001 to Thunderbird.

Comment 2

[[:MakeMyDay]]

There's another occurrence of DebuggerServer.openListener in CC - see http://mxr.mozilla.org/comm-central/source//suite/common/src/nsSuiteGlue.js#981

I don't know if this is an issue for Seamonkey - if so, they probably haven't noticed this, because they're swallowing any error for this.

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

The Seamonkey folks probably wouldn't mind if you fixed it for them :-P Up to you though if you have time.

Comment 4

[[:MakeMyDay]]

I don't mind to do so - who would be the one to request the review from?

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

I'd go with the same reviewer(s) as in bug 973530

Comment 6

[[:MakeMyDay]]

Attachment: FixRemoteDebuggerServer-TB-v2.diff

Updated patch for Thunderbird with removed whitespaces.

Comment 7

[[:MakeMyDay]]

Attachment: FixRemoteDebuggerServer-SM-v1.diff

Patch for Seamonkey.

Comment 8

[[e-mail]]

Comment on attachment 8540070 [details] [diff] [review]
FixRemoteDebuggerServer-SM-v1.diff

Thanks for the patch!

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 8540066 [details] [diff] [review]
FixRemoteDebuggerServer-TB-v2.diff

Review of attachment 8540066 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx! r=mkmelin

Comment 10

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/c44eb2f54c29
https://hg.mozilla.org/comm-central/rev/b23c7800c7a6

Comment 11

[Wayne Mery (:wsmwk)]

Confirm this now works.  I had tried 2014-12-26 build which failed.