AppleVDADecoder and AppleVTDecoder's destructor should be virtual

RESOLVED FIXED in Firefox 36

Status

()

Core
Audio/Video
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: jya, Assigned: jya)

Tracking

Trunk
mozilla37
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox36 fixed, firefox37 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
As title states.
(Assignee)

Comment 1

4 years ago
Created attachment 8539632 [details] [diff] [review]
Make AppleVT/VDA/AT/Decoder's destructors virtual

Make destructors virtual
Attachment #8539632 - Flags: review?(giles)
(Assignee)

Updated

4 years ago
Assignee: nobody → jyavenard
Status: NEW → ASSIGNED
Comment on attachment 8539632 [details] [diff] [review]
Make AppleVT/VDA/AT/Decoder's destructors virtual

Review of attachment 8539632 [details] [diff] [review]:
-----------------------------------------------------------------

Please say why you're making the change in the body of the commit message. I.e. these decoders are accessed through a base class, we want to protect against same. Whatever the motivation is here.

r=me with that change.
Attachment #8539632 - Flags: review?(giles) → review+
(Assignee)

Comment 3

4 years ago
Created attachment 8540121 [details] [diff] [review]
Make AppleVT/VDA/AT/Decoder's destructors virtual

Carrying r+
(Assignee)

Updated

4 years ago
Attachment #8539632 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/c70f446a6f15
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment on attachment 8540121 [details] [diff] [review]
Make AppleVT/VDA/AT/Decoder's destructors virtual

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing, sites more likely to serve Flash video.
[Describe test coverage new/current, TBPL]: landed on m-c.
[Risks and why]: Risk is minimal. This is a low-risk change to MSE-specific code.
[String/UUID change made/needed]: None.
Attachment #8540121 - Flags: approval-mozilla-aurora?
status-firefox36: --- → affected
status-firefox37: --- → fixed
Attachment #8540121 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.