Closed
Bug 1113045
Opened 9 years ago
Closed 9 years ago
AppleVDADecoder and AppleVTDecoder's destructor should be virtual
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: jya, Assigned: jya)
Details
Attachments
(1 file, 1 obsolete file)
3.13 KB,
patch
|
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
As title states.
Assignee | ||
Comment 1•9 years ago
|
||
Make destructors virtual
Attachment #8539632 -
Flags: review?(giles)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jyavenard
Status: NEW → ASSIGNED
Comment 2•9 years ago
|
||
Comment on attachment 8539632 [details] [diff] [review] Make AppleVT/VDA/AT/Decoder's destructors virtual Review of attachment 8539632 [details] [diff] [review]: ----------------------------------------------------------------- Please say why you're making the change in the body of the commit message. I.e. these decoders are accessed through a base class, we want to protect against same. Whatever the motivation is here. r=me with that change.
Attachment #8539632 -
Flags: review?(giles) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Carrying r+
Assignee | ||
Updated•9 years ago
|
Attachment #8539632 -
Attachment is obsolete: true
Assignee | ||
Comment 4•9 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/c70f446a6f15
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c70f446a6f15
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment 6•9 years ago
|
||
Comment on attachment 8540121 [details] [diff] [review] Make AppleVT/VDA/AT/Decoder's destructors virtual Approval Request Comment [Feature/regressing bug #]: MSE [User impact if declined]: Less consistent testing, sites more likely to serve Flash video. [Describe test coverage new/current, TBPL]: landed on m-c. [Risks and why]: Risk is minimal. This is a low-risk change to MSE-specific code. [String/UUID change made/needed]: None.
Attachment #8540121 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
status-firefox36:
--- → affected
status-firefox37:
--- → fixed
Updated•9 years ago
|
Attachment #8540121 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•